Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(merchant_account): add is_recon_enabled field in merchant_account #1713

Merged
merged 1 commit into from
Jul 18, 2023
Merged

feat(merchant_account): add is_recon_enabled field in merchant_account #1713

merged 1 commit into from
Jul 18, 2023

Conversation

anji-reddy-j
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added is_recon_enabled field in merchant_account table and sending it in retrive merchant_account api

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

  • This field will be used to know weather the merchant has recon service enabled or not

How did you test it?

  • check the merchant retrive api

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@anji-reddy-j anji-reddy-j requested review from a team as code owners July 14, 2023 10:36
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jul 14, 2023
@anji-reddy-j anji-reddy-j changed the title feat(merchant_account):add is_recon_enabled field in merchant_account feat(merchant_account): add is_recon_enabled field in merchant_account Jul 14, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jul 14, 2023
@anji-reddy-j anji-reddy-j force-pushed the recon_setup_v1 branch 3 times, most recently from 8d76d30 to 4c5dba6 Compare July 14, 2023 13:05
@anji-reddy-j anji-reddy-j requested a review from a team as a code owner July 14, 2023 13:05
@anji-reddy-j anji-reddy-j added C-feature Category: Feature request or enhancement M-database-changes Metadata: This PR involves database schema changes S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners labels Jul 18, 2023
@anji-reddy-j anji-reddy-j self-assigned this Jul 18, 2023
@anji-reddy-j anji-reddy-j added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jul 18, 2023
@anji-reddy-j
Copy link
Contributor Author

#1314

@anji-reddy-j anji-reddy-j mentioned this pull request Jul 18, 2023
Closed
2 tasks
@anji-reddy-j anji-reddy-j force-pushed the recon_setup_v1 branch 2 times, most recently from e50277a to 1f11bcc Compare July 18, 2023 11:40
@Narayanbhat166 Narayanbhat166 added this pull request to the merge queue Jul 18, 2023
Merged via the queue into main with commit 7549cd3 Jul 18, 2023
@Narayanbhat166 Narayanbhat166 deleted the recon_setup_v1 branch July 18, 2023 14:37
@SanchithHegde SanchithHegde removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners labels Jul 19, 2023
@SanchithHegde SanchithHegde linked an issue Jul 19, 2023 that may be closed by this pull request
[FEATURE] Adding recon dashboard in hyperswitch dashboard #1314
Closed
2 tasks
@SanchithHegde SanchithHegde mentioned this pull request Jul 19, 2023
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashokkjag ashokkjag ashokkjag approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@jagan-jaya jagan-jaya jagan-jaya approved these changes

@Abhicodes-crypto Abhicodes-crypto Abhicodes-crypto left review comments

Assignees

@anji-reddy-j anji-reddy-j

Labels
C-feature Category: Feature request or enhancement M-database-changes Metadata: This PR involves database schema changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Adding recon dashboard in hyperswitch dashboard
6 participants
@anji-reddy-j @jagan-jaya @Narayanbhat166 @ashokkjag @Abhicodes-crypto @SanchithHegde