Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): add pod information in metrics pipeline #1710

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Conversation

NishantJoshi00
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Adding server information in the metrics pipeline.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Adding information specific to the server in the metrics pipeline to support and mitigate issues against counter reset

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@NishantJoshi00 NishantJoshi00 added A-framework Area: Framework A-infra Area: Infrastructure S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jul 14, 2023
@NishantJoshi00 NishantJoshi00 self-assigned this Jul 14, 2023
@NishantJoshi00 NishantJoshi00 requested a review from a team as a code owner July 14, 2023 07:09
lsampras
lsampras previously approved these changes Jul 14, 2023
@SanchithHegde SanchithHegde merged commit cf145a3 into main Jul 19, 2023
@SanchithHegde SanchithHegde deleted the pod-metrics branch July 19, 2023 20:26
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-framework Area: Framework A-infra Area: Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants