Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(storage): update crate name to diesel models #1685

Merged
merged 4 commits into from
Jul 12, 2023
Merged

refactor(storage): update crate name to diesel models #1685

merged 4 commits into from
Jul 12, 2023

Conversation

lsampras
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • rename the storage models crate name to be more apt
  • future steps would involve creating a separate crate for data/domain models & splitting the functionality one change at a time

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

#1684

How did you test it?

  • CI + compilation since no logic was affected

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@lsampras lsampras self-assigned this Jul 12, 2023
@lsampras lsampras requested review from a team, jarnura and ashokkjag as code owners July 12, 2023 07:39
@lsampras lsampras added A-framework Area: Framework C-refactor Category: Refactor labels Jul 12, 2023
NishantJoshi00
NishantJoshi00 previously approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@NishantJoshi00 NishantJoshi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

SanchithHegde
SanchithHegde previously approved these changes Jul 12, 2023
View reviewed changes
@lsampras lsampras added this pull request to the merge queue Jul 12, 2023
Merged via the queue into main with commit 5a0e8be Jul 12, 2023
@lsampras lsampras deleted the split_data_models branch July 12, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NishantJoshi00 NishantJoshi00 NishantJoshi00 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@jarnura jarnura Awaiting requested review from jarnura

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

Assignees

@lsampras lsampras

Labels
A-framework Area: Framework C-refactor Category: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lsampras @SanchithHegde @NishantJoshi00