Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router): add expand attempts support in payments retrieve response #1678

Merged
merged 9 commits into from
Jul 14, 2023
Merged

feat(router): add expand attempts support in payments retrieve response #1678

merged 9 commits into from
Jul 14, 2023

Conversation

sai-harsha-vardhan
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Currently we only have active payment attempt details in payments retrieve response. For retries we would have multiple attempts, need an option to see all the attempts linked to payment intent.

Add expand_attempts in payments retrieve request, when enabled gives list of attempts linked to payment intent in response.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested Manually
image

image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@sai-harsha-vardhan sai-harsha-vardhan added A-core Area: Core flows C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed M-api-contract-changes Metadata: This PR involves API contract changes labels Jul 11, 2023
@sai-harsha-vardhan sai-harsha-vardhan added this to the July 2023 Release milestone Jul 11, 2023
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this Jul 11, 2023
@sai-harsha-vardhan sai-harsha-vardhan marked this pull request as ready for review July 11, 2023 11:22
@sai-harsha-vardhan sai-harsha-vardhan requested review from a team as code owners July 11, 2023 11:22
@jarnura jarnura added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jul 13, 2023
Narayanbhat166
Narayanbhat166 reviewed Jul 13, 2023
View reviewed changes
crates/api_models/src/payments.rs Outdated Show resolved Hide resolved
crates/api_models/src/payments.rs Outdated Show resolved Hide resolved
@jarnura jarnura added this pull request to the merge queue Jul 14, 2023
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jul 14, 2023
Merged via the queue into main with commit 8572f1d Jul 14, 2023
@jarnura jarnura deleted the expand-attempts-in-payments-response branch July 14, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@jarnura jarnura jarnura approved these changes

Assignees

@sai-harsha-vardhan sai-harsha-vardhan

Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes
Projects
None yet
Milestone
July 2023 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@sai-harsha-vardhan @jarnura @Narayanbhat166 @SanchithHegde