refactor(payment_methods): Remove legacy locker code as it is not been used #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShankarSinghC
added
A-core
ShankarSinghC
requested review from
SanchithHegde,
Narayanbhat166 and
inventvenkat
SanchithHegde
added
the
M-configuration-changes
ShankarSinghC
force-pushed
the
locker_refactor
branch
from
bccc2ea
to
d24881a
Compare
SanchithHegde
previously approved these changes
Jul 11, 2023
|
Why was |
Currently it's just been used in the case of Legacy locker, in future it might be used for some other purpose also. |
Narayanbhat166
previously approved these changes
Jul 11, 2023
vspecky
previously approved these changes
Jul 11, 2023
inventvenkat
previously approved these changes
Jul 12, 2023
ShankarSinghC
dismissed stale reviews from inventvenkat, vspecky, Narayanbhat166, and SanchithHegde
via
9afcf0b
Narayanbhat166
approved these changes
Jul 13, 2023
SanchithHegde
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Remove the legacy locker code from (crates/router/src/core/payment_methods/cards.rs) as we are no more using it. Also there are refactoring of certain functions as the locker_id was only used in case of legacy locker.
Additional Changes
Motivation and Context
How did you test it?
tested on custom pod
Checklist
cargo +nightly fmt --allcargo clippy