refactor(router): remove WebhookApiErrorSwitch and implement error mapping using ErrorSwitch

[PanGan21]

Type of Change

• Bugfix
• New feature
• Enhancement
• Refactoring
• Dependency updates
• Documentation
• CI/CD

Description

Additional Changes

• This PR modifies the API contract
• This PR modifies the database schema
• This PR modifies application configuration/environment variables

Motivation and Context

Refactor error mapping with WebhookApiErrorSwitch to make use of the existing ErrorSwitch trait which satisfies the same usecase.
Closes #1326

How did you test it?

Checklist

• I formatted the code cargo +nightly fmt --all
• I addressed lints thrown by cargo clippy
• I reviewed submitted code
• I added unit tests for my changes where possible
• I added a CHANGELOG entry if applicable

[PanGan21]

This line for example would give an error type annotations needed which is not fixed if I add the type

screenshot:

[vspecky]

@PanGan21 Hey, you need to bring the common_utils::errors::ReportSwitchExt trait into scope to use switch() there. impl ErrorSwitch<U> for T provides the T => U conversion logic, but we need additional functionality to promote this logic to support Result<R, error_stack::Report<T>> => Result<R, error_stack::Report<U>> (which is what get_dispute_details() returns and what disputes_incoming_webhook_flow() is expecting to be returned). The ReportSwitchExt trait and a corresponding impl imparts this functionality to all such Result types.

hyperswitch/crates/common_utils/src/errors.rs

Line 79 in 05ea08b

impl<T, U, V> ReportSwitchExt<T, U> for Result<T, error_stack::Report<V>>

[PanGan21]

@PanGan21 Hey, you need to bring the common_utils::errors::ReportSwitchExt trait into scope to use switch() there. impl ErrorSwitch<U> for T provides the T => U conversion logic, but we need additional functionality to promote this logic to support Result<R, error_stack::Report<T>> => Result<R, error_stack::Report<U>> (which is what get_dispute_details() returns and what disputes_incoming_webhook_flow() is expecting to be returned). The ReportSwitchExt trait and a corresponding impl imparts this functionality to all such Result types.

hyperswitch/crates/common_utils/src/errors.rs

Line 79 in 05ea08b

impl<T, U, V> ReportSwitchExt<T, U> for Result<T, error_stack::Report<V>>

It indeed did the trick! Thanks for the help and the insights. I will publish the pr then 😃

[SanchithHegde]

Thanks for the PR @PanGan21!