Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compatibility): fix AddressDetails in the customers flow #1654

Merged
merged 25 commits into from
Jul 13, 2023
Merged

fix(compatibility): fix AddressDetails in the customers flow #1654

merged 25 commits into from
Jul 13, 2023

Conversation

kritikmodi
Copy link
Contributor

@kritikmodi kritikmodi commented Jul 7, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • Refactoring

Description

Address of a new customer was being accepted as a SecretSerdeValue in the CustomerCreate and CustomerUpdate requests. This PR does the following :

  • Add a new struct AddressDetails in the customers flow for the address field.
  • Add the address field in Stripe Compatibility Layer and the corresponding mappings for it.
  • Add missing fields in CustomerCreate and CustomerUpdate requests as per Stripe API reference.

Motivation and Context

This PR closes the following issues :

#1646
#1649

How did you test it?

Manually

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code

@kritikmodi kritikmodi requested review from a team as code owners July 7, 2023 13:22
@kritikmodi kritikmodi self-assigned this Jul 7, 2023
@kritikmodi kritikmodi added A-stripe-compatibility-layer Area: Stripe Compatibility Layer A-customers Area: Customer Flow/API's C-bug Category: Bug C-refactor Category: Refactor P-high Priority: High labels Jul 7, 2023
@kritikmodi kritikmodi added this to the July 2023 Release milestone Jul 7, 2023
@kritikmodi kritikmodi changed the title fix(compatibility): update AddressDetails in customers in core and stripe compatibility layer fix(compatibility): update AddressDetails in customers flow Jul 7, 2023
@kritikmodi kritikmodi changed the title fix(compatibility): update AddressDetails in customers flow fix(compatibility): fix AddressDetails in customers flow Jul 7, 2023
@kritikmodi kritikmodi changed the title fix(compatibility): fix AddressDetails in customers flow fix(compatibility): fix AddressDetails in the customers flow Jul 7, 2023
This was linked to issues Jul 7, 2023
[BUG] Custom address struct not present in the /customers endpoints #1649
Closed
[BUG] customers endpoints refactoring in the Stripe Compatibility Layer #1646
Closed
@kritikmodi kritikmodi requested a review from a team as a code owner July 7, 2023 13:40
NishantJoshi00
NishantJoshi00 previously approved these changes Jul 11, 2023
View reviewed changes
inventvenkat
inventvenkat previously approved these changes Jul 11, 2023
View reviewed changes
@inventvenkat inventvenkat added this pull request to the merge queue Jul 13, 2023
Merged via the queue into main with commit f48d6c4 Jul 13, 2023
@inventvenkat inventvenkat deleted the stripe-layer-fixes-2 branch July 13, 2023 07:28
@SanchithHegde SanchithHegde removed the P-high Priority: High label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abhicodes-crypto Abhicodes-crypto Abhicodes-crypto approved these changes

@sahkal sahkal sahkal approved these changes

@inventvenkat inventvenkat inventvenkat approved these changes

@SanchithHegde SanchithHegde Awaiting requested review from SanchithHegde

@NishantJoshi00 NishantJoshi00 Awaiting requested review from NishantJoshi00

Assignees

@kritikmodi kritikmodi

Labels
A-customers Area: Customer Flow/API's A-stripe-compatibility-layer Area: Stripe Compatibility Layer C-bug Category: Bug C-refactor Category: Refactor
Projects
None yet
Milestone
July 2023 Release
6 participants
@kritikmodi @inventvenkat @sahkal @NishantJoshi00 @Abhicodes-crypto @SanchithHegde