Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(payment_methods): Fix db insert for payment method create #1651

Merged
merged 9 commits into from
Jul 13, 2023
Merged

refactor(payment_methods): Fix db insert for payment method create #1651

merged 9 commits into from
Jul 13, 2023

Conversation

Sarthak1799
Copy link
Contributor

@Sarthak1799 Sarthak1799 commented Jul 7, 2023 •
edited by pixincreate
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Currently, payment method create API does not insert payment method record in the Db.
have added the db call to insert the record if not already present.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

image image image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Sarthak1799 Sarthak1799 added C-feature Category: Feature request or enhancement A-payment-methods Area: Payment Methods labels Jul 7, 2023
@Sarthak1799 Sarthak1799 requested a review from a team as a code owner July 7, 2023 12:34
@Sarthak1799 Sarthak1799 self-assigned this Jul 7, 2023
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jul 7, 2023
@Sarthak1799 Sarthak1799 changed the title feature(payment methods): fix db insert for payment method create refactor(payment methods): fix db insert for payment method create Jul 10, 2023
@Sarthak1799 Sarthak1799 added C-refactor Category: Refactor and removed C-feature Category: Feature request or enhancement labels Jul 10, 2023
@pixincreate pixincreate changed the title refactor(payment methods): fix db insert for payment method create refactor(payment_methods): fix db insert for payment method create Jul 10, 2023
@github-actions github-actions bot added S-conventions-not-followed Status: This PR does not follow contributing guidelines and removed S-conventions-not-followed Status: This PR does not follow contributing guidelines labels Jul 10, 2023
@pixincreate pixincreate removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jul 10, 2023
@pixincreate pixincreate changed the title refactor(payment_methods): fix db insert for payment method create refactor(payment_methods): Fix db insert for payment method create Jul 10, 2023
@pixincreate pixincreate mentioned this pull request Jul 10, 2023
Merged
5 tasks
@pixincreate pixincreate added this to the July 2023 Release milestone Jul 10, 2023
@pixincreate pixincreate linked an issue Jul 10, 2023 that may be closed by this pull request
[BUG] payment_method_id is not being stored in payment_methods table #1541
Closed
2 tasks
pixincreate
pixincreate reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@pixincreate pixincreate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that, looks good to me.

crates/router/src/core/payment_methods/cards.rs Outdated Show resolved Hide resolved
pixincreate
pixincreate previously approved these changes Jul 10, 2023
View reviewed changes
@Sarthak1799 Sarthak1799 requested a review from jarnura July 11, 2023 07:57
@pixincreate pixincreate added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jul 11, 2023
@pixincreate pixincreate requested review from a team and ashokkjag as code owners July 12, 2023 10:19
Narayanbhat166
Narayanbhat166 previously approved these changes Jul 12, 2023
View reviewed changes
pixincreate
pixincreate previously approved these changes Jul 12, 2023
View reviewed changes
SanchithHegde
SanchithHegde reviewed Jul 12, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, looks good to me!

CHANGELOG.md Outdated Show resolved Hide resolved
@pixincreate pixincreate dismissed stale reviews from Narayanbhat166 and themself via 0a05ccf July 12, 2023 12:12
@pixincreate pixincreate added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jul 12, 2023
@pixincreate pixincreate mentioned this pull request Jul 12, 2023
Merged
4 tasks
@jarnura jarnura added this pull request to the merge queue Jul 13, 2023
Merged via the queue into main with commit 73f91a5 Jul 13, 2023
@jarnura jarnura deleted the PaymentMethod-dbInsert branch July 13, 2023 06:57
@bernard-eugine bernard-eugine added the P-high Priority: High label Jul 13, 2023
@SanchithHegde SanchithHegde removed the P-high Priority: High label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixincreate pixincreate pixincreate approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@jarnura jarnura jarnura approved these changes

@Sangamesh26 Sangamesh26 Awaiting requested review from Sangamesh26

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

@jagan-jaya jagan-jaya Awaiting requested review from jagan-jaya

@Narayanbhat166 Narayanbhat166 Awaiting requested review from Narayanbhat166

Assignees

@Sarthak1799 Sarthak1799

Labels
A-payment-methods Area: Payment Methods C-refactor Category: Refactor
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
July 2023 Release
Development

Successfully merging this pull request may close these issues.

[BUG] payment_method_id is not being stored in payment_methods table
6 participants
@Sarthak1799 @jarnura @SanchithHegde @Narayanbhat166 @pixincreate @bernard-eugine