-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CI): fix msrv checks on github run on push to main #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShankarSinghC
added
A-CI-CD
Area: Continuous Integration/Deployment
C-bug
Category: Bug
R-waiting-on-L1
Review: Waiting on L1 reviewer
labels
Jul 7, 2023
lsampras
approved these changes
Jul 7, 2023
lsampras
requested changes
Jul 7, 2023
lsampras
requested changes
Jul 7, 2023
SanchithHegde
added
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
and removed
R-waiting-on-L1
Review: Waiting on L1 reviewer
labels
Jul 7, 2023
ShankarSinghC
force-pushed
the
fix_msrv_checks
branch
from
July 7, 2023 14:17
c795567
to
cd61808
Compare
SanchithHegde
approved these changes
Jul 7, 2023
SanchithHegde
added
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
and removed
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
labels
Jul 7, 2023
lsampras
approved these changes
Jul 10, 2023
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Jul 10, 2023
@ShankarSinghC Can we also move |
AkshayaFoiger
added a commit
that referenced
this pull request
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR introduces changes to improve the CI workflow in the repository. The main goal is to separate the logic for pushes to the main branch from pull requests.
CI-push.yml
, specifically for pushes to the main branch.CI-push.yml
file.The logic we had in place for checking differences in crates in a pull request is not valid when we push directly to the main branch.
The
CI-push.yml
file contains a single job,push-to-main
, which runs on Ubuntu latest and performs the following steps:cargo hack check
command to check all workspace packages without considering specific differences.By separating the workflows, we can now ensure that CI builds on the main branch do not fail due to the logic designed for PRs. The
CI-push.yml
workflow specifically targets pushes to the main branch and performs the necessary cargo-hack checks on all workspace packages.Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy