fix(locker): remove delete_locker_payment_method_by_lookup_key from payments_operation_core #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShankarSinghC
added
A-core
github-actions
bot
added
the
S-conventions-not-followed
ShankarSinghC
changed the title
ShankarSinghC
removed
the
S-conventions-not-followed
vspecky
approved these changes
Jul 7, 2023
vspecky
added
R-waiting-on-L2
NishantJoshi00
approved these changes
Jul 7, 2023
Narayanbhat166
requested changes
Jul 7, 2023
SanchithHegde
added
S-waiting-on-author
Narayanbhat166
approved these changes
Jul 11, 2023
ShankarSinghC
added
R-waiting-on-L2
SanchithHegde
approved these changes
Jul 11, 2023
SanchithHegde
added
S-ready-for-merge
and removed
R-waiting-on-L2
SanchithHegde
removed
S-ready-for-merge
low-risk
15 tasks
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
The function call responsible for deleting card details from payments_operations_core() has been removed in this PR. This modification ensures that the redundant deletion of already deleted card details no longer occurs, preventing the unnecessary error from being triggered.
Additional Changes
Motivation and Context
Previously, there was a function call within payments_operations_core() that deleted card details stored in the Basilisk Locker V3. However, it was discovered that the process tracker was also attempting to delete the same card details, resulting in an unnecessary error when trying to delete an already deleted card.
How did you test it?
Manual, compiler-guided
Checklist
cargo +nightly fmt --allcargo clippy