Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Fix wallet payments throwing Invalid 'payment_method_type' provided and UI test issues #1633

Merged
merged 33 commits into from
Jul 10, 2023
Merged

fix(core): Fix wallet payments throwing Invalid 'payment_method_type' provided and UI test issues #1633

merged 33 commits into from
Jul 10, 2023

Conversation

pixincreate
Copy link
Member

@pixincreate pixincreate commented Jul 6, 2023 •
edited
Loading

Type of Change

  • Bugfix

Description

  • This PR fixes Invalid 'payment_method_type' provided error thrown by the connector.
  • Fix UI Test issues
  • Address Klarna failures
  • Update the credentials

Motivation and Context

We fixed many bugs.

How did you test it?

Manual through Github CI and through hs-payments-test

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code

@pixincreate pixincreate added A-core Area: Core flows C-bug Category: Bug labels Jul 6, 2023
@pixincreate pixincreate added this to the July 2023 Release milestone Jul 6, 2023
@pixincreate pixincreate self-assigned this Jul 6, 2023
@pixincreate pixincreate requested a review from a team as a code owner July 6, 2023 09:36
@pixincreate pixincreate marked this pull request as draft July 6, 2023 09:36
@pixincreate pixincreate added the P-high Priority: High label Jul 6, 2023
@pixincreate pixincreate added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jul 7, 2023
@SanchithHegde SanchithHegde added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jul 9, 2023
@jagan-jaya jagan-jaya added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jul 10, 2023
SanchithHegde
SanchithHegde previously approved these changes Jul 10, 2023
View reviewed changes
@jarnura jarnura added this pull request to the merge queue Jul 10, 2023
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jul 10, 2023
Merged via the queue into main with commit 307a470 Jul 10, 2023
@jarnura jarnura deleted the fix_wallet_payments branch July 10, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@jarnura jarnura jarnura approved these changes

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

@Narayanbhat166 Narayanbhat166 Awaiting requested review from Narayanbhat166

Assignees

@jagan-jaya jagan-jaya

@pixincreate pixincreate

Labels
A-core Area: Core flows C-bug Category: Bug
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
July 2023 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@pixincreate @jarnura @SanchithHegde @jagan-jaya