Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): [Globepay] Add template code for Globepay connector #1623

Merged
merged 25 commits into from
Jul 6, 2023

Conversation

srujanchikke
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Add connector Globepay as template code for future usage .

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Add connector Globepay as template code for future usage .

How did you test it?

template code testing not required

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@srujanchikke srujanchikke added A-connector-integration Area: Connector integration P-high Priority: High M-configuration-changes Metadata: This PR involves configuration changes R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jul 6, 2023
@srujanchikke srujanchikke self-assigned this Jul 6, 2023
@srujanchikke srujanchikke requested review from a team as code owners July 6, 2023 07:02
@srujanchikke srujanchikke requested review from a team as code owners July 6, 2023 07:02
prasunna09
prasunna09 previously approved these changes Jul 6, 2023
@srujanchikke srujanchikke added R-waiting-on-L2 Review: Waiting on L2 reviewer R-L1-completed Review: L1 Review completed and removed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jul 6, 2023
jagan-jaya
jagan-jaya previously approved these changes Jul 6, 2023
Base automatically changed from we_chat_pay_qr_code to main July 6, 2023 10:30
@SanchithHegde SanchithHegde dismissed stale reviews from jagan-jaya and prasunna09 July 6, 2023 10:30

The base branch was changed.

@srujanchikke srujanchikke requested a review from a team as a code owner July 6, 2023 10:30
@jagan-jaya jagan-jaya added this pull request to the merge queue Jul 6, 2023
Merged via the queue into main with commit 06f92c2 Jul 6, 2023
@jagan-jaya jagan-jaya deleted the add_globepay branch July 6, 2023 12:45
@SanchithHegde SanchithHegde removed P-high Priority: High R-waiting-on-L2 Review: Waiting on L2 reviewer R-L1-completed Review: L1 Review completed labels Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration M-configuration-changes Metadata: This PR involves configuration changes
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

6 participants