Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connector): [Rapyd] Add router_return_url in 3DS request #1621

Merged
merged 2 commits into from
Jul 6, 2023
Merged

fix(connector): [Rapyd] Add router_return_url in 3DS request #1621

merged 2 commits into from
Jul 6, 2023

Conversation

ShankarSinghC
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

3DS payment status would always remain in requires_customer_action as there was no return url provided in the 3DS request. This pr adds router_return_url in 3DS request.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Screenshot 2023-07-05 at 5 31 52 PM Screenshot 2023-07-05 at 6 01 56 PM Screenshot 2023-07-05 at 5 32 08 PM Screenshot 2023-07-05 at 6 00 37 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ShankarSinghC ShankarSinghC added A-connector-integration Area: Connector integration C-bug Category: Bug R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jul 5, 2023
@ShankarSinghC ShankarSinghC self-assigned this Jul 5, 2023
@ShankarSinghC ShankarSinghC requested a review from a team as a code owner July 5, 2023 13:22
@ArjunKarthik ArjunKarthik added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Jul 5, 2023
@ShankarSinghC ShankarSinghC removed the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Jul 5, 2023
@ShankarSinghC ShankarSinghC added this to the July 2023 Release milestone Jul 5, 2023
@SanchithHegde SanchithHegde changed the title fix(rapyd): add router_return_url in 3DS request fix(connector): [Rapyd] Add router_return_url in 3DS request Jul 6, 2023
@Narayanbhat166 Narayanbhat166 added this pull request to the merge queue Jul 6, 2023
Merged via the queue into main with commit e913bfc Jul 6, 2023
@Narayanbhat166 Narayanbhat166 deleted the fix_rapyd_3ds branch July 6, 2023 07:27
@SanchithHegde SanchithHegde removed the R-waiting-on-L1 Review: Waiting on L1 reviewer label Jul 7, 2023
@pixincreate pixincreate mentioned this pull request Aug 9, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujanchikke srujanchikke srujanchikke approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Assignees

@ShankarSinghC ShankarSinghC

Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
July 2023 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@ShankarSinghC @ArjunKarthik @SanchithHegde @Narayanbhat166 @srujanchikke