Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [DummyConnector] add new dummy connectors #1609

Merged
merged 5 commits into from
Jul 5, 2023
Merged

feat(connector): [DummyConnector] add new dummy connectors #1609

merged 5 commits into from
Jul 5, 2023

Conversation

ThisIsMani
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR adds new dummy connectors and refactor dummy connector errors.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

This is to make dummy connectors more obvious.

How did you test it?

Postman

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ThisIsMani ThisIsMani requested review from a team as code owners July 5, 2023 06:42
@ThisIsMani ThisIsMani self-assigned this Jul 5, 2023
@ThisIsMani ThisIsMani added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jul 5, 2023
@ThisIsMani ThisIsMani modified the milestone: July 2023 Release Jul 5, 2023
@ThisIsMani ThisIsMani requested a review from a team as a code owner July 5, 2023 07:42
@jarnura jarnura added this pull request to the merge queue Jul 5, 2023
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jul 5, 2023
Merged via the queue into main with commit cf7b672 Jul 5, 2023
@jarnura jarnura deleted the dummy-connector branch July 5, 2023 12:58
@ThisIsMani ThisIsMani mentioned this pull request Jul 25, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NishantJoshi00 NishantJoshi00 NishantJoshi00 approved these changes

@jarnura jarnura jarnura approved these changes

@jagan-jaya jagan-jaya jagan-jaya approved these changes

@lsampras lsampras Awaiting requested review from lsampras

@SanchithHegde SanchithHegde Awaiting requested review from SanchithHegde

Assignees

@ThisIsMani ThisIsMani

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ThisIsMani @jagan-jaya @jarnura @NishantJoshi00 @SanchithHegde