Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(payments): add connector_metadata, metadata and feature_metadata fields in payments, remove udf field #1595

Merged
merged 26 commits into from
Jul 5, 2023
Merged

feat(payments): add connector_metadata, metadata and feature_metadata fields in payments, remove udf field #1595

merged 26 commits into from
Jul 5, 2023

Conversation

Abhicodes-crypto
Copy link
Contributor

@Abhicodes-crypto Abhicodes-crypto commented Jul 3, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

In this PR ,

API CONTRACT CHANGES

In PaymentsRequest 3 fields are added :

  • connector_metadata(typed),
  • feature_metadata(typed),
  • metadata(can take any json),

also previous backwards compatibility to accept order_details in metadata is removed.

This is a breaking change and it has been decided to not make it backwards compatible.

DB CHANGES

  • removed udf field from payments.
  • added fields :
    • allowed_payment_method_types JSON,
    • connector_metadata JSON,
    • feature_metadata JSON;

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested order_category. It works. And made sure get_trackers payment_data.payment_intent is populated with the fields.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Abhicodes-crypto Abhicodes-crypto added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed M-database-changes Metadata: This PR involves database schema changes M-api-contract-changes Metadata: This PR involves API contract changes labels Jul 3, 2023
@Abhicodes-crypto Abhicodes-crypto requested a review from a team as a code owner July 3, 2023 08:07
@Abhicodes-crypto Abhicodes-crypto self-assigned this Jul 3, 2023
@Abhicodes-crypto Abhicodes-crypto requested review from a team as code owners July 3, 2023 08:07
@dracarys18 dracarys18 added the S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author label Jul 3, 2023
@Abhicodes-crypto Abhicodes-crypto removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jul 4, 2023
@Abhicodes-crypto Abhicodes-crypto added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jul 4, 2023
@Abhicodes-crypto Abhicodes-crypto removed the S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author label Jul 4, 2023
@SanchithHegde SanchithHegde added S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jul 4, 2023
@Abhicodes-crypto Abhicodes-crypto added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jul 5, 2023
Narayanbhat166
Narayanbhat166 previously approved these changes Jul 5, 2023
View reviewed changes
jarnura
jarnura reviewed Jul 5, 2023
View reviewed changes
crates/api_models/src/payments.rs Outdated Show resolved Hide resolved
crates/api_models/src/payments.rs Outdated Show resolved Hide resolved
@Abhicodes-crypto Abhicodes-crypto linked an issue Jul 5, 2023 that may be closed by this pull request
[FEATURE] add connector_metadata, metadata and feature_metadata fields in payments, remove udf field #1613
Closed
2 tasks
@Abhicodes-crypto Abhicodes-crypto removed the S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author label Jul 5, 2023
@bernard-eugine bernard-eugine added this pull request to the merge queue Jul 5, 2023
Merged via the queue into main with commit e713b62 Jul 5, 2023
@bernard-eugine bernard-eugine deleted the payments-metadata-refactor branch July 5, 2023 12:47
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@jarnura jarnura jarnura approved these changes

@SanchithHegde SanchithHegde Awaiting requested review from SanchithHegde

Assignees

@Abhicodes-crypto Abhicodes-crypto

Labels
A-core Area: Core flows M-api-contract-changes Metadata: This PR involves API contract changes M-database-changes Metadata: This PR involves database schema changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] add connector_metadata, metadata and feature_metadata fields in payments, remove udf field
6 participants
@Abhicodes-crypto @jarnura @Narayanbhat166 @SanchithHegde @dracarys18 @bernard-eugine