Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): [Adyen] implement Online Banking Thailand for Adyen #1585

Merged
merged 92 commits into from
Jul 20, 2023

Conversation

AkshayaFoiger
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Online Banking Thailand is a Thailand specific payment method.

"payment_method": "bank_redirect",
  "payment_method_type": "online_banking_thailand",
  "payment_method_data": {
    "bank_redirect": {
      "online_banking_thailand": {
        "issuer": "bangkok_bank"
      }
    }
  }

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

How did you test it?

Unit Test Case
Screen Shot 2023-07-02 at 11 25 41 AM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

Base automatically changed from adyen/onlineBankingFPX to main July 20, 2023 11:52
@ArjunKarthik ArjunKarthik dismissed their stale review July 20, 2023 11:52

The base branch was changed.

ArjunKarthik
ArjunKarthik previously approved these changes Jul 20, 2023
jagan-jaya
jagan-jaya previously approved these changes Jul 20, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Jul 20, 2023
Merged via the queue into main with commit 0c3cf05 Jul 20, 2023
@ArjunKarthik ArjunKarthik deleted the adyen/online_banking_thailand branch July 20, 2023 17:48
@SanchithHegde SanchithHegde removed P-high Priority: High S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer ageing >2weeks Created > 2 weeks labels Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes M-configuration-changes Metadata: This PR involves configuration changes
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

6 participants