Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [Adyen] Implement Gcash for Adyen #1576

Merged
merged 58 commits into from
Jul 18, 2023
Merged

feat(connector): [Adyen] Implement Gcash for Adyen #1576

merged 58 commits into from
Jul 18, 2023

Conversation

AkshayaFoiger
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Philippine Specific payment method

"payment_method_type": "gcash",
  "payment_method_data": {
    "wallet": {
      "gcash_redirect": {}
    }
  }

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

How did you test it?

Tested it using hs-payments-test.netlify.app
Screen Shot 2023-06-30 at 10 02 21 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

AkshayaFoiger and others added 21 commits June 26, 2023 11:58
@AkshayaFoiger AkshayaFoiger requested review from a team as code owners June 30, 2023 16:33
@AkshayaFoiger AkshayaFoiger self-assigned this Jun 30, 2023
@AkshayaFoiger AkshayaFoiger added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jun 30, 2023
SanchithHegde
SanchithHegde previously approved these changes Jun 30, 2023
View reviewed changes
@ArjunKarthik ArjunKarthik dismissed stale reviews from srujanchikke and SanchithHegde July 18, 2023 09:18

The base branch was changed.

@AkshayaFoiger AkshayaFoiger requested review from srujanchikke and removed request for jarnura and ashokkjag July 18, 2023 10:23
srujanchikke
srujanchikke previously approved these changes Jul 18, 2023
View reviewed changes
ArjunKarthik
ArjunKarthik previously approved these changes Jul 18, 2023
View reviewed changes
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Jul 18, 2023
Merged via the queue into main with commit df0ef15 Jul 18, 2023
@ArjunKarthik ArjunKarthik deleted the adyen/gcash branch July 18, 2023 13:05
@SanchithHegde SanchithHegde removed ageing >2weeks Created > 2 weeks P-high Priority: High S-ready-for-merge labels Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujanchikke srujanchikke srujanchikke approved these changes

@ashokkjag ashokkjag ashokkjag approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@SanchithHegde SanchithHegde SanchithHegde left review comments

@jagan-jaya jagan-jaya jagan-jaya left review comments

Assignees

@AkshayaFoiger AkshayaFoiger

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes M-configuration-changes Metadata: This PR involves configuration changes
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AkshayaFoiger @jagan-jaya @ArjunKarthik @SanchithHegde @ashokkjag @srujanchikke @bernard-eugine