Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [Adyen] implement Kakao for Adyen #1558

Merged
merged 45 commits into from
Jul 18, 2023
Merged

feat(connector): [Adyen] implement Kakao for Adyen #1558

merged 45 commits into from
Jul 18, 2023

Conversation

AkshayaFoiger
Copy link
Contributor

@AkshayaFoiger AkshayaFoiger commented Jun 28, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Kakao pay is a South Korean specific payment method.

"payment_method_type": "kakao_pay",
  "payment_method_data": {
    "wallet": {
      "kakao_pay_redirect": {}
    }
  }

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

How did you test it?

Tested it using hs-payments-test.netlify.app
Screen Shot 2023-06-28 at 11 44 48 AM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@AkshayaFoiger AkshayaFoiger requested review from a team as code owners June 28, 2023 06:36
@AkshayaFoiger AkshayaFoiger self-assigned this Jun 28, 2023
@AkshayaFoiger AkshayaFoiger added A-connector-integration Area: Connector integration M-api-contract-changes Metadata: This PR involves API contract changes R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jun 28, 2023
SanchithHegde
SanchithHegde reviewed Jun 28, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, looks good to me!

crates/router/tests/connectors/adyen_uk_ui.rs Outdated Show resolved Hide resolved
crates/router/src/connector/adyen/transformers.rs Outdated Show resolved Hide resolved
@SanchithHegde SanchithHegde added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jun 28, 2023
@AkshayaFoiger AkshayaFoiger changed the base branch from main to adyen/GoPay June 29, 2023 09:57
@AkshayaFoiger AkshayaFoiger added the C-feature Category: Feature request or enhancement label Jun 30, 2023
@AkshayaFoiger AkshayaFoiger removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author labels Jul 14, 2023
Base automatically changed from adyen/GoPay to main July 17, 2023 13:05
@ArjunKarthik ArjunKarthik dismissed stale reviews from jagan-jaya, SanchithHegde, and themself July 17, 2023 13:05

The base branch was changed.

@bernard-eugine bernard-eugine added the ageing >2weeks Created > 2 weeks label Jul 18, 2023
@ArjunKarthik ArjunKarthik added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-ready-for-merge labels Jul 18, 2023
@AkshayaFoiger AkshayaFoiger removed the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Jul 18, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Jul 18, 2023
Merged via the queue into main with commit 11ad9be Jul 18, 2023
@ArjunKarthik ArjunKarthik deleted the adyen/kakao_pay branch July 18, 2023 09:18
@SanchithHegde SanchithHegde removed P-high Priority: High ageing >2weeks Created > 2 weeks labels Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde left review comments

@lsampras lsampras lsampras approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@jagan-jaya jagan-jaya jagan-jaya left review comments

Assignees

@AkshayaFoiger AkshayaFoiger

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AkshayaFoiger @jagan-jaya @ArjunKarthik @lsampras @SanchithHegde @bernard-eugine