-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connector): [Stripe] Add support for WeChat Pay and Qr code support in next action #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syncing with the remote repository
Pulled from main
Sangamesh26
added
A-connector-integration
Area: Connector integration
A-core
Area: Core flows
C-feature
Category: Feature request or enhancement
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
A-payment-methods
Area: Payment Methods
labels
Jun 27, 2023
SanchithHegde
added
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
S-needs-conflict-resolution
Status: This PR needs conflicts to be resolved by the author
labels
Jun 28, 2023
Sangamesh26
added
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
and removed
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
S-needs-conflict-resolution
Status: This PR needs conflicts to be resolved by the author
labels
Jul 5, 2023
jagan-jaya
requested changes
Jul 5, 2023
jagan-jaya
added
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
and removed
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Jul 5, 2023
Sangamesh26
added
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
and removed
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
labels
Jul 5, 2023
srujanchikke
force-pushed
the
we_chat_pay_qr_code
branch
from
July 6, 2023 05:58
1bcd646
to
dbcacc9
Compare
jagan-jaya
approved these changes
Jul 6, 2023
SanchithHegde
approved these changes
Jul 6, 2023
sahkal
added
the
M-api-contract-changes
Metadata: This PR involves API contract changes
label
Jul 6, 2023
SanchithHegde
removed
P-high
Priority: High
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-connector-integration
Area: Connector integration
A-core
Area: Core flows
A-payment-methods
Area: Payment Methods
C-feature
Category: Feature request or enhancement
M-api-contract-changes
Metadata: This PR involves API contract changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Add support for WeChat Pay, we chat pay in stripe doesn't follow redirection.Qr code url is given in the next action, this qr code has to be shown in sdk.
API contract for WeChat Pay:
Additional Changes
Motivation and Context
Add support for WeChat Pay payment method
How did you test it?
Manual
Qr code url in next action
Qr code
Checklist
cargo +nightly fmt --all
cargo clippy