-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Changed frm_config format type in merchant_connector_account and added frm_message in payments response #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… changes api contract and db schema
…added frm_message
…formers.rs....formatted with cargo clippy
github-actions
bot
added
the
S-conventions-not-followed
Status: This PR does not follow contributing guidelines
label
Jun 26, 2023
SanchithHegde
changed the title
dependency_updates(core): Make email feature optional, and changed frm_config and payments response for frm changes in VAS
dependency_updates(core): Make email feature optional, and changed frm_config and payments response
Jun 28, 2023
jagan-jaya
requested changes
Jul 11, 2023
jagan-jaya
added
the
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
label
Jul 11, 2023
jagan-jaya
changed the title
dependency_updates(core): Make email feature optional, and changed frm_config and payments response
dependency_updates(core): Make email feature optional and changed frm_config and payments response
Jul 11, 2023
jagan-jaya
changed the title
dependency_updates(core): Make email feature optional and changed frm_config and payments response
feat(core): Make email feature optional and changed frm_config and payments response
Jul 11, 2023
github-actions
bot
removed
the
S-conventions-not-followed
Status: This PR does not follow contributing guidelines
label
Jul 11, 2023
jagan-jaya
requested changes
Jul 11, 2023
jarnura
requested changes
Jul 21, 2023
); | ||
|
||
CREATE TABLE fraud_check ( | ||
id SERIAL PRIMARY KEY, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to move away from auto increment ids
for any distributed storage related approaches. And migration without downtime with auto-increment id's also hard. So don't need this field
… fetch fraud_check table entry
…y as (frm_id, payment_id, merchant_id)
…switch into make-email-feature-optional
… before and after frm_configs migration to avoid db entries like this {null}
jagan-jaya
previously approved these changes
Jul 26, 2023
jarnura
approved these changes
Jul 26, 2023
jagan-jaya
approved these changes
Jul 26, 2023
SanchithHegde
added
A-core
Area: Core flows
C-feature
Category: Feature request or enhancement
and removed
P-high
Priority: High
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
ageing >2weeks
Created > 2 weeks
labels
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
These changes are done for FRM related improvements:
Additional Changes
changes in DB schema to change type of frm_configs:
changed the API contract for merchant_connector_account.... frm_configs field changed to :
Motivation and Context
Needed to change these, so that they can be consumed by our FRM module.
How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy