Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compatibility): add straight through routing and udf mapping in setup intent #1536

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

sahkal
Copy link
Contributor

@sahkal sahkal commented Jun 23, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

added straight through routing and udf field mapping to get txn_id and other details in setup_intents

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Euler needs txn_id to verify the txns started at euler's end.

How did you test it?

Tested locally through postman
Screen Shot 2023-06-23 at 11 21 02 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@sahkal sahkal requested a review from a team as a code owner June 23, 2023 18:02
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jun 23, 2023
@sahkal sahkal self-assigned this Jun 23, 2023
@sahkal sahkal added the R-waiting-on-L1 Review: Waiting on L1 reviewer label Jun 23, 2023
@SanchithHegde SanchithHegde changed the title enhan(compatibility): added straight through routing and udf mapping … feat(compatibility): add straight through routing and udf mapping in setup intent Jun 24, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jun 24, 2023
@sahkal sahkal added the C-feature Category: Feature request or enhancement label Jun 25, 2023
Copy link
Member

@jarnura jarnura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than import changes, looks good to me.

item.connector.and_then(|v| v.into_iter().next());

let routing = routable_connector
.map(crate::types::api::RoutingAlgorithm::Single)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.map(crate::types::api::RoutingAlgorithm::Single)
.map(api::RoutingAlgorithm::Single)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@sahkal sahkal requested a review from jarnura June 27, 2023 08:08
@sahkal sahkal added this to the June 2023 Release milestone Jun 27, 2023
@SanchithHegde SanchithHegde added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jul 1, 2023
@jarnura jarnura requested a review from vspecky July 3, 2023 11:51
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jul 3, 2023
@jarnura jarnura added this pull request to the merge queue Jul 3, 2023
Merged via the queue into main with commit 1e87f3d Jul 3, 2023
@jarnura jarnura deleted the add-direct-routing-in-setup-intent branch July 3, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants