Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router): implement PaymentMethodInterface for MockDB #1535

Merged
merged 7 commits into from
Jun 26, 2023
Merged

feat(router): implement PaymentMethodInterface for MockDB #1535

merged 7 commits into from
Jun 26, 2023

Conversation

PanGan21
Copy link
Contributor

@PanGan21 PanGan21 commented Jun 23, 2023 •
edited by pixincreate
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

The main motivation is to have MockDb stubs, help to void mocking, and invocation of external database api's.
For more information check #172

Fixes #1491.

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@PanGan21 PanGan21 requested a review from a team as a code owner June 23, 2023 14:26
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jun 23, 2023
@PanGan21 PanGan21 changed the title Feat 1491 mockdb payment method interface feat(router): implement PaymentMethodInterface for MockDB Jun 23, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jun 23, 2023
@PanGan21 PanGan21 changed the title feat(router): implement PaymentMethodInterface for MockDB feat(router): implement PaymentMethodInterface for MockDB Jun 23, 2023
@PanGan21 PanGan21 changed the title feat(router): implement PaymentMethodInterface for MockDB feat(router): implement PaymentMethodInterface for MockDB Jun 23, 2023
@pixincreate pixincreate added A-core Area: Core flows C-feature Category: Feature request or enhancement S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jun 23, 2023
@pixincreate
Copy link
Member

pixincreate commented Jun 23, 2023 •
edited
Loading

Kindly format the code with cargo +nightly fmt --all and address the changes requested by clippy.

SanchithHegde
SanchithHegde reviewed Jun 23, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, looks good to me!

Thanks for the PR, @PanGan21!

crates/router/src/db/payment_method.rs Outdated Show resolved Hide resolved
crates/router/src/db/payment_method.rs Show resolved Hide resolved
@SanchithHegde SanchithHegde added A-framework Area: Framework and removed A-core Area: Core flows labels Jun 23, 2023
@SanchithHegde SanchithHegde added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jun 24, 2023
@SanchithHegde SanchithHegde added the low-risk label to track PRs which might have less impact on hyperswitch after merge label Jun 24, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue Jun 26, 2023
@SanchithHegde SanchithHegde added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jun 26, 2023
Merged via the queue into juspay:main with commit 772fc84 Jun 26, 2023
@SanchithHegde SanchithHegde removed S-ready-for-merge low-risk label to track PRs which might have less impact on hyperswitch after merge labels Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixincreate pixincreate pixincreate left review comments

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@dracarys18 dracarys18 dracarys18 approved these changes

@lsampras lsampras Awaiting requested review from lsampras

@Narayanbhat166 Narayanbhat166 Awaiting requested review from Narayanbhat166

@NishantJoshi00 NishantJoshi00 Awaiting requested review from NishantJoshi00

Assignees

@PanGan21 PanGan21

Labels
A-framework Area: Framework C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement PaymentMethodInterface for MockDb
4 participants
@PanGan21 @pixincreate @SanchithHegde @dracarys18