Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(disputes): update 4xx error for Files - Delete endpoint #1531

Merged
merged 7 commits into from
Jul 4, 2023
Merged

fix(disputes): update 4xx error for Files - Delete endpoint #1531

merged 7 commits into from
Jul 4, 2023

Conversation

kritikmodi
Copy link
Contributor

@kritikmodi kritikmodi commented Jun 23, 2023 •
edited
Loading

Type of Change

  • Bugfix

Description

Introduced new error FileProviderNotSupported and fixed the error mapping for the Files - Delete endpoint thrown when the file storage is not router.

Motivation and Context

This PR solves this issue.

How did you test it?

Tested manually using Postman.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code

@kritikmodi kritikmodi requested review from a team as code owners June 23, 2023 12:55
@kritikmodi kritikmodi linked an issue Jun 23, 2023 that may be closed by this pull request
[BUG] Validate and update 4xx in Files - Delete endpoint #1512
Closed
2 tasks
@kritikmodi kritikmodi self-assigned this Jun 23, 2023
@kritikmodi kritikmodi added C-bug Category: Bug A-disputes Area: Dispute flows labels Jun 23, 2023
@kritikmodi kritikmodi added this to the June 2023 Release milestone Jun 23, 2023
@kritikmodi kritikmodi requested a review from a team as a code owner June 26, 2023 08:56
SanchithHegde
SanchithHegde previously approved these changes Jun 28, 2023
View reviewed changes
@SanchithHegde SanchithHegde added S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author labels Jun 28, 2023
@kritikmodi kritikmodi removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author labels Jun 30, 2023
@SanchithHegde SanchithHegde added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jun 30, 2023
@inventvenkat inventvenkat added this pull request to the merge queue Jul 4, 2023
Merged via the queue into main with commit eabe16c Jul 4, 2023
@inventvenkat inventvenkat deleted the issue-1523 branch July 4, 2023 06:11
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@inventvenkat inventvenkat inventvenkat approved these changes

@lsampras lsampras Awaiting requested review from lsampras

Assignees

@kritikmodi kritikmodi

Labels
A-disputes Area: Dispute flows C-bug Category: Bug
Projects
None yet
Milestone
June 2023 Release
Development

Successfully merging this pull request may close these issues.

[BUG] Validate and update 4xx in Files - Delete endpoint
4 participants
@kritikmodi @inventvenkat @lsampras @SanchithHegde