Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(payment_method): [upi] add new payment method and use in iatapay #1528

Merged
merged 5 commits into from
Jun 30, 2023
Merged

feat(payment_method): [upi] add new payment method and use in iatapay #1528

merged 5 commits into from
Jun 30, 2023

Conversation

arvindpatel24
Copy link
Contributor

@arvindpatel24 arvindpatel24 commented Jun 23, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@arvindpatel24 arvindpatel24 requested review from a team as code owners June 23, 2023 12:17
@arvindpatel24 arvindpatel24 self-assigned this Jun 23, 2023
@arvindpatel24 arvindpatel24 added C-feature Category: Feature request or enhancement A-payment-methods Area: Payment Methods S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners R-L1-completed Review: L1 Review completed labels Jun 23, 2023
@arvindpatel24 arvindpatel24 added this to the June 2023 Release milestone Jun 23, 2023
SanchithHegde
SanchithHegde previously approved these changes Jun 24, 2023
View reviewed changes
@SanchithHegde SanchithHegde added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer and removed S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners R-L1-completed Review: L1 Review completed labels Jun 24, 2023
@SanchithHegde
Copy link
Member

@arvindpatel24 Please address the failing OpenAPI spec check.

@arvindpatel24 arvindpatel24 requested a review from a team as a code owner June 25, 2023 02:37
ArjunKarthik
ArjunKarthik requested changes Jun 26, 2023
View reviewed changes
crates/api_models/src/payments.rs Outdated Show resolved Hide resolved
@ArjunKarthik ArjunKarthik added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jun 26, 2023
@arvindpatel24 arvindpatel24 added S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jun 26, 2023
ArjunKarthik
ArjunKarthik previously approved these changes Jun 27, 2023
View reviewed changes
jagan-jaya
jagan-jaya reviewed Jun 27, 2023
View reviewed changes
crates/router/src/connector/iatapay/transformers.rs
#[derive(Debug, Serialize)]
#[serde(rename_all = "camelCase")]
pub struct PayerInfo {
token_id: Secret<String>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this token for, add a one line comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, currently this token is used to pass vpa_id (as suggested by Iatapay), but for different payment method it will be different payment_method_data. So, it is just a format of request for Iatapay, we can't define any fix thing for it in the code.

@SanchithHegde SanchithHegde added S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author and removed S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jun 28, 2023
@arvindpatel24 arvindpatel24 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author labels Jun 30, 2023
@jagan-jaya
Copy link
Contributor

@arvindpatel24 is this checked in VAS also?

@SanchithHegde SanchithHegde added this pull request to the merge queue Jun 30, 2023
Merged via the queue into main with commit 2d11bf5 Jun 30, 2023
@SanchithHegde SanchithHegde deleted the upi-v1 branch June 30, 2023 14:48
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@jagan-jaya jagan-jaya jagan-jaya approved these changes

Assignees

@arvindpatel24 arvindpatel24

Labels
A-payment-methods Area: Payment Methods C-feature Category: Feature request or enhancement
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
June 2023 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@arvindpatel24 @SanchithHegde @jagan-jaya @ArjunKarthik @Narayanbhat166