Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): [Adyen] Add support for Samsung Pay #1525

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Conversation

Sangamesh26
Copy link
Contributor

Type of Change

  • New feature

Description

Add support for Samsung Pay through Adyen.

Steps for Samsung Pay:

  1. Download samsung sdk, after following some sdk calls, sdk gets payment token.
  2. This payment token is passed in confirm call
  3. We get direct terminal status from Adyen

Api contract for samsung pay :

    "payment_method": "wallet",
    "payment_method_type": "samsung_pay",
    "payment_method_data": {
        "wallet": {
            "samsung_pay": {
                "token": "fghjkmgdfghjkl;dfghjkl;'mbedjsnjfkcnk"
            }
        }
    },

Additional Changes

  • This PR modifies the API contract

Motivation and Context

Add support for new payment method

How did you test it?

Can't test it now, as sdk doesn't support this flow.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code

@Sangamesh26 Sangamesh26 added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-payment-methods Area: Payment Methods M-api-contract-changes Metadata: This PR involves API contract changes labels Jun 23, 2023
@Sangamesh26 Sangamesh26 requested a review from a team as a code owner June 23, 2023 11:17
@Sangamesh26 Sangamesh26 self-assigned this Jun 23, 2023
@Sangamesh26 Sangamesh26 requested a review from a team as a code owner June 23, 2023 11:17
@Sangamesh26 Sangamesh26 requested a review from a team as a code owner June 23, 2023 11:45
@SanchithHegde SanchithHegde changed the title feat(connector): [Adyen] add support for samsung pay feat(connector): [Adyen] Add support for Samsung Pay Jun 24, 2023
@ArjunKarthik ArjunKarthik added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jun 28, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue Jun 28, 2023
@ArjunKarthik ArjunKarthik added the low-risk label to track PRs which might have less impact on hyperswitch after merge label Jun 28, 2023
Merged via the queue into main with commit 33309da Jun 28, 2023
@SanchithHegde SanchithHegde deleted the samsung_pay branch June 28, 2023 09:27
@SanchithHegde SanchithHegde removed S-ready-for-merge low-risk label to track PRs which might have less impact on hyperswitch after merge labels Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration A-payment-methods Area: Payment Methods M-api-contract-changes Metadata: This PR involves API contract changes
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants