Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): Convert state of US and CA in ISO format for cybersource connector #1506

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

jagan-jaya
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Cybersource only accepts state in US and CA in ISO format as 2 digits like AL, AB. but our system is sending the state input as full name so connector throws error. to avoid this we will always convert the state to ISO format incase of cybersource.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

To fix country-state issue in cybersource, as dashboard can't send different state name for different connector.

How did you test it?

Screen Shot 2023-06-22 at 4 07 26 PM Screen Shot 2023-06-22 at 4 07 43 PM Screen Shot 2023-06-22 at 4 13 53 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code

@jagan-jaya jagan-jaya added the A-connector-integration Area: Connector integration label Jun 22, 2023
@jagan-jaya jagan-jaya requested a review from a team as a code owner June 22, 2023 10:45
@jagan-jaya jagan-jaya self-assigned this Jun 22, 2023
@jagan-jaya jagan-jaya requested review from a team as code owners June 22, 2023 10:45
@jagan-jaya jagan-jaya requested review from a team, jarnura and ashokkjag as code owners June 22, 2023 10:53
@ashokkjag ashokkjag added this pull request to the merge queue Jun 22, 2023
Merged via the queue into main with commit 4a047ce Jun 22, 2023
@SanchithHegde SanchithHegde deleted the fix-cybersource-state-issue branch June 24, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

6 participants