Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router): add filters for refunds #1501

Merged
merged 7 commits into from
Jun 30, 2023
Merged

feat(router): add filters for refunds #1501

merged 7 commits into from
Jun 30, 2023

Conversation

apoorvdixit88
Copy link
Contributor

@apoorvdixit88 apoorvdixit88 commented Jun 21, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added filters for refunds. Filters work on the basis of timerange, connector, currency and refund_status.
Modified the refunds/list API and added refunds/filter API to extract filters.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Used postman to test filters.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@apoorvdixit88 apoorvdixit88 requested a review from a team as a code owner June 21, 2023 13:14
@apoorvdixit88 apoorvdixit88 self-assigned this Jun 21, 2023
@apoorvdixit88 apoorvdixit88 requested a review from a team as a code owner June 21, 2023 13:14
@apoorvdixit88 apoorvdixit88 added C-feature Category: Feature request or enhancement R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jun 21, 2023
@apoorvdixit88 apoorvdixit88 force-pushed the filter-refunds branch 4 times, most recently from eae8cad to e54b0b9 Compare June 21, 2023 18:50
SanchithHegde
SanchithHegde reviewed Jun 21, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please attach suitable labels to the PR. This is definitely a breaking API contract change.

crates/api_models/src/refunds.rs Outdated Show resolved Hide resolved
crates/api_models/src/refunds.rs Outdated Show resolved Hide resolved
crates/api_models/src/refunds.rs Outdated Show resolved Hide resolved
crates/api_models/src/refunds.rs Outdated Show resolved Hide resolved
crates/router/src/db/refund.rs Outdated Show resolved Hide resolved
crates/router/src/routes/app.rs Outdated Show resolved Hide resolved
crates/router/src/types/storage/refund.rs Outdated Show resolved Hide resolved
crates/router/src/routes/refunds.rs Outdated Show resolved Hide resolved
crates/router/src/types/storage/refund.rs Outdated Show resolved Hide resolved
@SanchithHegde SanchithHegde added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Jun 21, 2023
@apoorvdixit88 apoorvdixit88 force-pushed the filter-refunds branch 2 times, most recently from e900bc9 to 7b631f7 Compare June 23, 2023 14:14
SanchithHegde
SanchithHegde reviewed Jun 24, 2023
View reviewed changes
crates/api_models/src/refunds.rs Outdated Show resolved Hide resolved
crates/api_models/src/refunds.rs Show resolved Hide resolved
crates/api_models/src/refunds.rs Show resolved Hide resolved
crates/api_models/src/refunds.rs Show resolved Hide resolved
crates/api_models/src/refunds.rs Show resolved Hide resolved
crates/router/src/consts.rs Outdated Show resolved Hide resolved
crates/router/src/core/refunds/validator.rs Show resolved Hide resolved
crates/router/src/db/refund.rs Outdated Show resolved Hide resolved
crates/router/src/db/refund.rs Outdated Show resolved Hide resolved
crates/router/src/db/refund.rs Outdated Show resolved Hide resolved
lsampras
lsampras requested changes Jun 24, 2023
View reviewed changes
crates/router/src/core/refunds.rs Outdated Show resolved Hide resolved
crates/router/src/core/refunds.rs Outdated Show resolved Hide resolved
crates/router/src/routes/refunds.rs Outdated Show resolved Hide resolved
crates/router/src/types/storage/refund.rs Outdated Show resolved Hide resolved
crates/router/src/types/storage/refund.rs Outdated Show resolved Hide resolved
crates/api_models/src/refunds.rs Show resolved Hide resolved
crates/api_models/src/refunds.rs Outdated Show resolved Hide resolved
crates/api_models/src/refunds.rs Outdated Show resolved Hide resolved
crates/router/src/core/refunds/validator.rs Show resolved Hide resolved
crates/router/src/types/storage/refund.rs Outdated Show resolved Hide resolved
@apoorvdixit88 apoorvdixit88 added the M-api-contract-changes Metadata: This PR involves API contract changes label Jun 26, 2023
@lsampras lsampras added the A-refunds Area: Refund flows label Jun 27, 2023
@apoorvdixit88 apoorvdixit88 removed the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Jun 27, 2023
@apoorvdixit88 apoorvdixit88 added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jun 27, 2023
SanchithHegde
SanchithHegde previously approved these changes Jun 27, 2023
View reviewed changes
lsampras
lsampras previously approved these changes Jun 27, 2023
View reviewed changes
crates/router/src/db/refund.rs Outdated Show resolved Hide resolved
crates/router/src/db/refund.rs Outdated Show resolved Hide resolved
@apoorvdixit88 apoorvdixit88 removed the R-waiting-on-L1 Review: Waiting on L1 reviewer label Jun 28, 2023
inventvenkat
inventvenkat previously approved these changes Jun 29, 2023
View reviewed changes
@lsampras lsampras added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jun 30, 2023
@inventvenkat inventvenkat added this pull request to the merge queue Jun 30, 2023
Merged via the queue into main with commit 88860b9 Jun 30, 2023
@inventvenkat inventvenkat deleted the filter-refunds branch June 30, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@lsampras lsampras lsampras approved these changes

@inventvenkat inventvenkat inventvenkat approved these changes

@jarnura jarnura Awaiting requested review from jarnura

@racnan racnan Awaiting requested review from racnan

Assignees

@apoorvdixit88 apoorvdixit88

Labels
A-refunds Area: Refund flows C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apoorvdixit88 @inventvenkat @lsampras @SanchithHegde