Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(response-log): add logging to the response for stripe compatibility layer #1470

Merged
merged 4 commits into from
Jun 19, 2023
Merged

feat(response-log): add logging to the response for stripe compatibility layer #1470

merged 4 commits into from
Jun 19, 2023

Conversation

ShankarSinghC
Copy link
Contributor

@ShankarSinghC ShankarSinghC commented Jun 17, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description




This PR enhances the Stripe compatibility as it logs response in the compatibility_api_wrap.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Screenshot 2023-06-19 at 11 53 27 AM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ShankarSinghC ShankarSinghC added A-core Area: Core flows R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jun 17, 2023
@ShankarSinghC ShankarSinghC requested a review from a team as a code owner June 17, 2023 12:39
@ShankarSinghC ShankarSinghC self-assigned this Jun 17, 2023
@ShankarSinghC ShankarSinghC requested review from a team as code owners June 17, 2023 12:39
lsampras
lsampras reviewed Jun 17, 2023
View reviewed changes
Copy link
Member

@lsampras lsampras left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the most part,
Can you add a PR description as well

& screenshots of the log lines...

crates/router/src/connector/airwallex/transformers.rs Outdated Show resolved Hide resolved
@lsampras lsampras added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jun 17, 2023
@jarnura jarnura added the low-risk label to track PRs which might have less impact on hyperswitch after merge label Jun 19, 2023
@ShankarSinghC ShankarSinghC added R-waiting-on-L1 Review: Waiting on L1 reviewer and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jun 19, 2023
@lsampras lsampras removed the R-waiting-on-L1 Review: Waiting on L1 reviewer label Jun 19, 2023
@lsampras lsampras added this pull request to the merge queue Jun 19, 2023
Merged via the queue into main with commit 96c71e1 Jun 19, 2023
@lsampras lsampras deleted the compatibility_api branch June 19, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixincreate pixincreate pixincreate left review comments

@Abhicodes-crypto Abhicodes-crypto Abhicodes-crypto approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@lsampras lsampras lsampras approved these changes

@dracarys18 dracarys18 Awaiting requested review from dracarys18

Assignees

@ShankarSinghC ShankarSinghC

Labels
A-core Area: Core flows low-risk label to track PRs which might have less impact on hyperswitch after merge
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ShankarSinghC @lsampras @SanchithHegde @Abhicodes-crypto @pixincreate @jarnura @SamraatBansal