Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [Noon] Add GooglePay, ApplePay, PayPal Support #1450

Merged
merged 3 commits into from
Jun 15, 2023
Merged

feat(connector): [Noon] Add GooglePay, ApplePay, PayPal Support #1450

merged 3 commits into from
Jun 15, 2023

Conversation

SamraatBansal
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Add Support for wallets

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@SamraatBansal SamraatBansal requested a review from a team as a code owner June 15, 2023 10:28
@SamraatBansal SamraatBansal self-assigned this Jun 15, 2023
@SamraatBansal SamraatBansal added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement P-high Priority: High S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jun 15, 2023
jagan-jaya
jagan-jaya previously approved these changes Jun 15, 2023
View reviewed changes
@jagan-jaya jagan-jaya added this pull request to the merge queue Jun 15, 2023
Merged via the queue into main with commit 8ebcc1c Jun 15, 2023
@SanchithHegde SanchithHegde removed P-high Priority: High S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jun 17, 2023
@SanchithHegde SanchithHegde deleted the noon-wallets-integ branch June 17, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@jagan-jaya jagan-jaya jagan-jaya approved these changes

Assignees

@SamraatBansal SamraatBansal

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SamraatBansal @jagan-jaya @ArjunKarthik @SanchithHegde