Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stripe): fix logs on stripe connector integration #1448

Merged
merged 1 commit into from
Jun 15, 2023
Merged

fix(stripe): fix logs on stripe connector integration #1448

merged 1 commit into from
Jun 15, 2023

Conversation

NishantJoshi00
Copy link
Member

@NishantJoshi00 NishantJoshi00 commented Jun 15, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Splitting the transformation and encoding part on stripe body construction

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@NishantJoshi00 NishantJoshi00 added C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jun 15, 2023
@NishantJoshi00 NishantJoshi00 self-assigned this Jun 15, 2023
@NishantJoshi00 NishantJoshi00 requested a review from a team as a code owner June 15, 2023 09:55
@jarnura jarnura enabled auto-merge June 15, 2023 10:00
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jun 15, 2023
@jarnura jarnura added this pull request to the merge queue Jun 15, 2023
Merged via the queue into main with commit c42b436 Jun 15, 2023
@SanchithHegde SanchithHegde deleted the mask-and-log-v2 branch June 17, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura jarnura approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Assignees

@NishantJoshi00 NishantJoshi00

Labels
C-bug Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NishantJoshi00 @ArjunKarthik @jarnura @SanchithHegde