fix(connector): [Bluesnap] fix expiry year #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prasunna09
added
A-connector-integration
github-actions
bot
added
the
S-conventions-not-followed
jagan-jaya
previously approved these changes
Jun 13, 2023
prasunna09
changed the title
prasunna09
changed the title
github-actions
bot
removed
the
S-conventions-not-followed
ArjunKarthik
previously approved these changes
Jun 13, 2023
|
Closing this pull request as the conversion from a 2-digit to 4-digit year is no longer needed. The validation in #1416 will always expect a 4-digit year. |
|
We need this PR as we are allowing 2 digits expiry year in HS |
jagan-jaya
added
S-ready-for-merge
and removed
S-waiting-on-review
jarnura
previously approved these changes
Jun 14, 2023
jarnura
added
S-needs-conflict-resolution
prasunna09
dismissed stale reviews from jarnura, ArjunKarthik, and jagan-jaya
via
7f81577
jagan-jaya
approved these changes
Jun 14, 2023
ArjunKarthik
approved these changes
Jun 14, 2023
prasunna09
added
S-waiting-on-review
jagan-jaya
added
S-ready-for-merge
and removed
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
When a 2-digit expiry year is sent to Bluesnap, an error is thrown stating 'Problematic Input.' To address this, the 2-digit expiry year should be converted to a 4-digit expiry year.
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy