Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(fix): [Adyen] Fix bug in Adyen #1375

Merged
merged 13 commits into from
Jun 16, 2023
Merged

refactor(fix): [Adyen] Fix bug in Adyen #1375

merged 13 commits into from
Jun 16, 2023

Conversation

swangi-kumari
Copy link
Contributor

@swangi-kumari swangi-kumari commented Jun 7, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Fixed bug:

  1. Added support for 2 digits expiry year. (earlier it was accepting only 4digit exp year.)
  2. In card 3DS, additional browser_info support was added as it was mandatory field for getting url.
  3. Fixed Card Mandates for multi use mandate type. (for multiple payments from merchant side)
  4. Fixed webhooks source verification.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Using Postman

2 digit support is working now
Screen Shot 2023-06-15 at 12 51 44 PM

if we don't provide browser_info it will give proper error
Screen Shot 2023-06-15 at 2 24 58 PM

webhooks
Screen Shot 2023-06-15 at 12 51 44 PM (2)

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@swangi-kumari swangi-kumari requested a review from a team as a code owner June 7, 2023 06:40
@swangi-kumari swangi-kumari self-assigned this Jun 7, 2023
@swangi-kumari swangi-kumari added R-waiting-on-L1 Review: Waiting on L1 reviewer A-connector-integration Area: Connector integration labels Jun 7, 2023
@swangi-kumari swangi-kumari requested a review from a team as a code owner June 8, 2023 11:54
@jagan-jaya jagan-jaya added S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author labels Jun 13, 2023
jagan-jaya
jagan-jaya previously approved these changes Jun 13, 2023
View reviewed changes
@prasunna09 prasunna09 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author labels Jun 13, 2023
Sangamesh26
Sangamesh26 previously approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@Sangamesh26 Sangamesh26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@jagan-jaya jagan-jaya removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jun 14, 2023
@prasunna09 prasunna09 added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Jun 14, 2023
jagan-jaya
jagan-jaya previously approved these changes Jun 15, 2023
View reviewed changes
@Sangamesh26
Copy link
Contributor

@swangi-kumari please attach the screen shot of the response.

@jagan-jaya jagan-jaya removed the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Jun 16, 2023
@jarnura jarnura added this pull request to the merge queue Jun 16, 2023
Merged via the queue into main with commit d3a6906 Jun 16, 2023
@SanchithHegde SanchithHegde deleted the adyen_bug_fix branch June 17, 2023 07:57
@SanchithHegde SanchithHegde removed S-ready-for-merge R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sangamesh26 Sangamesh26 Sangamesh26 approved these changes

@jarnura jarnura jarnura approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@jagan-jaya jagan-jaya jagan-jaya approved these changes

Assignees

@swangi-kumari swangi-kumari

Labels
A-connector-integration Area: Connector integration
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@swangi-kumari @Sangamesh26 @jagan-jaya @ArjunKarthik @jarnura @SanchithHegde @prasunna09 @Narayanbhat166