Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): fix docker compose local setup #1372

Merged
merged 4 commits into from
Jun 7, 2023
Merged

Conversation

lsampras
Copy link
Member

@lsampras lsampras commented Jun 6, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Add the missing encryption key in docker compose toml file
  • Remove the 2-part build for docker-compose servers
  • Remove the extra trailing whitespaces throughout the project

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

  • The docker_compose.toml file is used for building docker compose images, hence this needs to be regularly updated & kept in sync with the local development counterpart...
  • The 2-part docker setup was confusing for most folks unless they dug deep into the parts, reverting it in favor of a simpler (but slower) single part docker step

How did you test it?

  • ran the setup locally from scratch

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@lsampras lsampras added C-doc Category: Documentation updates S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jun 6, 2023
@lsampras lsampras self-assigned this Jun 6, 2023
@lsampras lsampras requested review from a team, jarnura and ashokkjag as code owners June 6, 2023 19:38
@ashokkjag ashokkjag added this pull request to the merge queue Jun 7, 2023
@SanchithHegde SanchithHegde added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jun 7, 2023
Merged via the queue into main with commit d21fcc7 Jun 7, 2023
@SanchithHegde SanchithHegde deleted the fix_docker_configs branch June 7, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-doc Category: Documentation updates
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants