-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(errors): refactor actix_web::ResponseError
for ApiErrorResponse
#1362
Conversation
This definitely looks like a quality of life change. But, earlier we were planning to refactor/remove the macro that we were using to construct the |
b911c02
actix_web::ResponseError
for ApiErrorResponse
I'll be attaching the |
Type of Change
Description
Two sources of truth for which http status_code that is sent in the final response. Fixed it in this PR.
Ideally
impl actix_web::ResponseError for api_error_response::ApiErrorResponse
should be removed but it results in too many changes so implemented it differently in this PR.Additional Changes
Motivation and Context
How did you test it?
compiles
Checklist
cargo +nightly fmt --all
cargo clippy