-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(order_details): Adding order_details both inside and outside of metadata, in payments request, for backward compatibility #1344
Merged
bernard-eugine
merged 13 commits into
main
from
order_details_for_backward_compatibility
Jun 14, 2023
Merged
feat(order_details): Adding order_details both inside and outside of metadata, in payments request, for backward compatibility #1344
bernard-eugine
merged 13 commits into
main
from
order_details_for_backward_compatibility
Jun 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…request, for backward compatibility
github-actions
bot
added
the
S-conventions-not-followed
Status: This PR does not follow contributing guidelines
label
Jun 3, 2023
rishavkar
added
A-connector-compatibility
Area: Connector compatibility
C-feature
Category: Feature request or enhancement
M-database-changes
Metadata: This PR involves database schema changes
M-api-contract-changes
Metadata: This PR involves API contract changes
and removed
S-conventions-not-followed
Status: This PR does not follow contributing guidelines
labels
Jun 3, 2023
rishavkar
changed the title
Adding order_details both inside and outside of metadata, in payments request, for backward compatibility
feat(order_details):Adding order_details both inside and outside of metadata, in payments request, for backward compatibility
Jun 3, 2023
github-actions
bot
added
the
S-conventions-not-followed
Status: This PR does not follow contributing guidelines
label
Jun 3, 2023
rishavkar
changed the title
feat(order_details):Adding order_details both inside and outside of metadata, in payments request, for backward compatibility
feat(payment_request):Adding order_details both inside and outside of metadata, in payments request, for backward compatibility
Jun 3, 2023
rishavkar
removed
the
S-conventions-not-followed
Status: This PR does not follow contributing guidelines
label
Jun 5, 2023
rishavkar
changed the title
feat(payment_request):Adding order_details both inside and outside of metadata, in payments request, for backward compatibility
feat(payment_request) : Adding order_details both inside and outside of metadata, in payments request, for backward compatibility
Jun 5, 2023
github-actions
bot
added
the
S-conventions-not-followed
Status: This PR does not follow contributing guidelines
label
Jun 5, 2023
Narayanbhat166
added
the
S-needs-conflict-resolution
Status: This PR needs conflicts to be resolved by the author
label
Jun 5, 2023
rishavkar
changed the title
feat(payment_request) : Adding order_details both inside and outside of metadata, in payments request, for backward compatibility
feat(order_details): Adding order_details both inside and outside of metadata, in payments request, for backward compatibility
Jun 5, 2023
github-actions
bot
removed
the
S-conventions-not-followed
Status: This PR does not follow contributing guidelines
label
Jun 5, 2023
Narayanbhat166
requested changes
Jun 5, 2023
jarnura
requested changes
Jun 6, 2023
rishavkar
added
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Jun 7, 2023
Narayanbhat166
requested changes
Jun 9, 2023
Narayanbhat166
requested changes
Jun 9, 2023
migrations/2023-05-29-094747_order-details-as-a-separate-column.sql/up.sql
Outdated
Show resolved
Hide resolved
Narayanbhat166
removed
the
S-waiting-on-approval
Status: Review completed, awaiting for approvals from code-owners
label
Jun 9, 2023
There are few files which are conflicting, please resolve them. |
There are a lot of places where the clones can be avoided, since we are only checking if the value is present and not consuming it. You can instead use |
rishavkar
removed
the
S-needs-conflict-resolution
Status: This PR needs conflicts to be resolved by the author
label
Jun 12, 2023
Narayanbhat166
approved these changes
Jun 12, 2023
jarnura
approved these changes
Jun 13, 2023
jarnura
approved these changes
Jun 13, 2023
jarnura
added
S-ready-for-merge
and removed
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-connector-compatibility
Area: Connector compatibility
C-feature
Category: Feature request or enhancement
M-api-contract-changes
Metadata: This PR involves API contract changes
M-database-changes
Metadata: This PR involves database schema changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding order_details both inside and outside of metadata, in payments request, for backward compatibility
Type of Change
Description
Previously order_details was inside metadata as an object.
But we want to keep order_details outside metadata, as an array of objects.
So accepting both of these order_details, for backward compatibility.
If we accept order_details inside metadata in Payments_create, we also need to send it inside metadata for payment update and confirm, and vice versa.
Also, order_details cannot be passed both inside and outside metadata for payments request.
Additional Changes
DB change: field "order_details" added to payment_intent
API contract change: payments request has an extra field "order_details"
Motivation and Context
How did you test it?
https://docs.google.com/document/d/18NuXDQdSGTIjpJsVULs19XQHNFmygdJdCPA8J5_PfJw/edit
Checklist
cargo +nightly fmt --all
cargo clippy