Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: customer id is not mandatory during confirm #1317

Merged
merged 4 commits into from
May 31, 2023
Merged

fix: customer id is not mandatory during confirm #1317

merged 4 commits into from
May 31, 2023

Conversation

Narayanbhat166
Copy link
Member

Type of Change

  • Bugfix

Description

This Pr will not check for the customer_id present in the confirm request during mandates request.

Motivation and Context

How did you test it?

  • Create a mandate payment, with confirm as false
Screenshot 2023-05-30 at 1 33 56 PM
  • confirm the mandate payment, without customer id
Screenshot 2023-05-30 at 1 34 30 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code

@Narayanbhat166 Narayanbhat166 added A-core Area: Core flows C-bug Category: Bug labels May 30, 2023
@Narayanbhat166 Narayanbhat166 added this to the May 2023 Release milestone May 30, 2023
@Narayanbhat166 Narayanbhat166 self-assigned this May 30, 2023
@Narayanbhat166 Narayanbhat166 requested a review from a team as a code owner May 30, 2023 08:05
@Narayanbhat166 Narayanbhat166 force-pushed the fix_connector_customer_id_for_mandates branch from c3e4556 to 1310e20 Compare May 30, 2023 09:20
@Narayanbhat166 Narayanbhat166 requested review from a team, jarnura and ashokkjag as code owners May 30, 2023 09:20
@Narayanbhat166 Narayanbhat166 changed the base branch from 1229-bug-incorrect-mapping-of-connector-customer to main May 30, 2023 09:20
@Narayanbhat166 Narayanbhat166 added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label May 30, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue May 31, 2023
@SanchithHegde SanchithHegde added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 31, 2023
Merged via the queue into main with commit 1261791 May 31, 2023
@SanchithHegde SanchithHegde deleted the fix_connector_customer_id_for_mandates branch May 31, 2023 21:31
@Sangamesh26 Sangamesh26 mentioned this pull request Jun 5, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abhicodes-crypto Abhicodes-crypto Abhicodes-crypto approved these changes

@NishantJoshi00 NishantJoshi00 NishantJoshi00 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@Sangamesh26 Sangamesh26 Awaiting requested review from Sangamesh26

@jarnura jarnura Awaiting requested review from jarnura

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

Assignees

@Narayanbhat166 Narayanbhat166

Labels
A-core Area: Core flows C-bug Category: Bug
Projects
None yet
Milestone
May 2023 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@Narayanbhat166 @SanchithHegde @NishantJoshi00 @Abhicodes-crypto