Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): Add refund and dispute webhooks for Rapyd #1313

Merged
merged 12 commits into from
Jun 28, 2023
Merged

feat(connector): Add refund and dispute webhooks for Rapyd #1313

merged 12 commits into from
Jun 28, 2023

Conversation

ShankarSinghC
Copy link
Contributor

@ShankarSinghC ShankarSinghC commented May 30, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Implemented refund and dispute webhooks for Rapyd

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

I tested this change manually

Out going dispute webhook to merchant
Screenshot 2023-05-29 at 10 02 48 PM

Out going refund webhook to merchant
Screenshot 2023-05-30 at 9 48 43 AM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ShankarSinghC ShankarSinghC added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 30, 2023
@ShankarSinghC ShankarSinghC self-assigned this May 30, 2023
@ShankarSinghC ShankarSinghC requested a review from a team as a code owner May 30, 2023 06:21
@ShankarSinghC ShankarSinghC requested review from a team, jarnura and ashokkjag as code owners May 30, 2023 06:28
@ShankarSinghC ShankarSinghC added R-waiting-on-L1 Review: Waiting on L1 reviewer and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 30, 2023
@ShankarSinghC ShankarSinghC requested review from jagan-jaya and removed request for jagan-jaya May 30, 2023 14:20
SanchithHegde
SanchithHegde reviewed May 31, 2023
View reviewed changes
crates/router/src/connector/rapyd.rs Outdated Show resolved Hide resolved
crates/router/src/connector/rapyd/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/rapyd/transformers.rs Outdated Show resolved Hide resolved
@SanchithHegde SanchithHegde added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed R-waiting-on-L1 Review: Waiting on L1 reviewer labels May 31, 2023
@ShankarSinghC ShankarSinghC added R-waiting-on-L1 Review: Waiting on L1 reviewer and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels May 31, 2023
sai-harsha-vardhan
sai-harsha-vardhan requested changes May 31, 2023
View reviewed changes
crates/router/src/connector/rapyd.rs Outdated Show resolved Hide resolved
crates/router/src/connector/rapyd/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/rapyd/transformers.rs Outdated Show resolved Hide resolved
SanchithHegde
SanchithHegde previously approved these changes Jun 4, 2023
View reviewed changes
jagan-jaya
jagan-jaya requested changes Jun 8, 2023
View reviewed changes
crates/router/src/connector/rapyd.rs Outdated Show resolved Hide resolved
@jagan-jaya jagan-jaya added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Jun 8, 2023
@ShankarSinghC ShankarSinghC removed the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Jun 12, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue Jun 28, 2023
Merged via the queue into main with commit db011f3 Jun 28, 2023
@SanchithHegde SanchithHegde deleted the rapyd_webhooks branch June 28, 2023 14:51
@SanchithHegde SanchithHegde removed the R-waiting-on-L1 Review: Waiting on L1 reviewer label Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@jagan-jaya jagan-jaya jagan-jaya approved these changes

@jarnura jarnura Awaiting requested review from jarnura

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

Assignees

@ShankarSinghC ShankarSinghC

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShankarSinghC @jagan-jaya @SanchithHegde @sai-harsha-vardhan