fix(connector): [Shift4]Add Refund webhooks #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chikke srujan <[email protected]>
srujanchikke
added
A-connector-integration
github-actions
bot
added
the
S-conventions-not-followed
srujanchikke
changed the title
srujanchikke
changed the title
github-actions
bot
removed
the
S-conventions-not-followed
prasunna09
reviewed
May 30, 2023
ArjunKarthik
added
the
S-waiting-on-author
Signed-off-by: chikke srujan <[email protected]>
srujanchikke
removed
the
S-waiting-on-author
prasunna09
previously approved these changes
May 31, 2023
prasunna09
added
R-waiting-on-L2
jagan-jaya
requested changes
Jun 8, 2023
| ), | ||
| )) | ||
| } else { | ||
| Err(errors::ConnectorError::WebhookEventTypeNotFound).into_report() |
There was a problem hiding this comment.
Suggested change
| Err(errors::ConnectorError::WebhookEventTypeNotFound).into_report() | |
| Err(errors::ConnectorError::WebhookReferenceIdNotFound).into_report() |
| impl From<Shift4WebhookEvent> for api::IncomingWebhookEvent { | ||
| fn from(event: Shift4WebhookEvent) -> Self { | ||
| match event { | ||
| Shift4WebhookEvent::ChargeSucceeded | Shift4WebhookEvent::ChargeUpdated => { |
There was a problem hiding this comment.
why ChargeSucceeded is also mapped as PaymentIntentProcessing
do we get ChargeCaptured for automatic capture_method also from shift4?
There was a problem hiding this comment.
reference from shift4 ChargeSucceded is when charge is created sucessfully , and charge captured Occurs when a charge is captured. No we are not getting chargeCaptured for automatic but , as per their documentation i have mapped the status .
jagan-jaya
added
the
S-waiting-on-author
Signed-off-by: chikke srujan <[email protected]>
…erswitch into add_webhook_support_to_shift4
Signed-off-by: chikke srujan <[email protected]>
srujanchikke
added
S-waiting-on-review
jagan-jaya
approved these changes
Jun 12, 2023
ArjunKarthik
approved these changes
Jun 14, 2023
jagan-jaya
added
S-ready-for-merge
and removed
S-waiting-on-review
SanchithHegde
removed
S-ready-for-merge
R-L1-completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Refund webhook support for shift4 (status mapping ref) . We always update the status by psync as we don't have source verification for shift4 .
Additional Changes
Motivation and Context
How did you test it?
payment webhook
Refund webhook
Checklist
cargo +nightly fmt --allcargo clippy