feat: use subscriber client for subscription in pubsub #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracarys18
added
A-core
inventvenkat
requested changes
May 29, 2023
lsampras
approved these changes
May 29, 2023
NishantJoshi00
approved these changes
May 29, 2023
inventvenkat
approved these changes
May 29, 2023
Narayanbhat166
approved these changes
May 29, 2023
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
use
SubscriberClientfor subscriber instead ofRedisClient.Motivation and Context
SubscriberClientfromfredhas extensive features on top ofRedisClientwhich spawns a tokio task which will automatically resubscribe to the channel in case if it closes for any reason.How did you test it?
Manual
Checklist
cargo +nightly fmt --allcargo clippy