Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): subscriber return type #1292

Merged
merged 4 commits into from
May 31, 2023
Merged

Conversation

dracarys18
Copy link
Member

Type of Change

  • Bugfix

Description

Fixes subscriber error message on the startup.

Motivation and Context

NA

How did you test it?

Manual

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code

@dracarys18 dracarys18 added C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 29, 2023
@dracarys18 dracarys18 self-assigned this May 29, 2023
@dracarys18 dracarys18 requested a review from a team as a code owner May 29, 2023 07:50
Narayanbhat166
Narayanbhat166 previously approved these changes May 29, 2023
lsampras
lsampras previously approved these changes May 29, 2023
@Narayanbhat166 Narayanbhat166 added this pull request to the merge queue May 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch May 29, 2023
@dracarys18 dracarys18 dismissed stale reviews from lsampras and Narayanbhat166 via 12bc0ec May 29, 2023 13:48
@dracarys18 dracarys18 changed the title fix: subscriber return type fix(router): subscriber return type May 31, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue May 31, 2023
@SanchithHegde SanchithHegde added S-ready-for-merge A-framework Area: Framework and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 31, 2023
Merged via the queue into main with commit 55bb117 May 31, 2023
@SanchithHegde SanchithHegde deleted the fix_subscribe_err_message branch May 31, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-framework Area: Framework C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants