refactor(connector_customer): incorrect mapping of connector customer #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narayanbhat166
added
A-core
2 tasks
Narayanbhat166
requested review from
a team,
jarnura and
ashokkjag
as code owners
jarnura
previously approved these changes
May 31, 2023
jagan-jaya
approved these changes
May 31, 2023
jarnura
approved these changes
May 31, 2023
SanchithHegde
deleted the
1229-bug-incorrect-mapping-of-connector-customer
branch
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR adds support for multiple country and business label support in the connector customer. Previously the mapping to connector customer was of the form
connector_name -> connector_customer_id, This has been changed toconnector_label -> connector_customer_idThis Pr also includes some changes to the connector customer code to use idiomatic rust.
Motivation and Context
Fixes #1229
How did you test it?
Create a payment through stripe, and check whether connector customer is generated.
Create a mandate transaction in confirm, without passing the customer id.
Checklist
cargo +nightly fmt --allcargo clippy