Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kms): reduce redundant kms calls #1264

Merged
merged 2 commits into from
May 25, 2023
Merged

feat(kms): reduce redundant kms calls #1264

merged 2 commits into from
May 25, 2023

Conversation

NishantJoshi00
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR introduces changes to changes to KMS decryption:

  • It decrypts and stores the KMS keys for vault and locker in a AppState.
  • It performs concurrent decryption while startup for those KMS keys
  • It also supports, retry mechanism for decryption for failures

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Improve the performance

How did you test it?

compiler guided

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@NishantJoshi00 NishantJoshi00 added A-framework Area: Framework A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 25, 2023
@NishantJoshi00 NishantJoshi00 added this to the May 2023 Release milestone May 25, 2023
@NishantJoshi00 NishantJoshi00 requested review from a team as code owners May 25, 2023 06:02
@NishantJoshi00 NishantJoshi00 self-assigned this May 25, 2023
jarnura
jarnura requested changes May 25, 2023
View reviewed changes
crates/router/src/routes/app.rs Outdated Show resolved Hide resolved
@jarnura jarnura added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 25, 2023
ashokkjag
ashokkjag reviewed May 25, 2023
View reviewed changes
crates/router/src/configs/settings.rs Show resolved Hide resolved
crates/router/src/routes/app.rs Outdated Show resolved Hide resolved
@NishantJoshi00 NishantJoshi00 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels May 25, 2023
@jarnura jarnura enabled auto-merge May 25, 2023 08:59
@jarnura jarnura added this pull request to the merge queue May 25, 2023
Merged via the queue into main with commit 71a17c6 May 25, 2023
@jarnura jarnura removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label May 25, 2023
@SanchithHegde SanchithHegde deleted the kms-reduce-calls branch May 25, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashokkjag ashokkjag ashokkjag approved these changes

@jarnura jarnura jarnura approved these changes

@inventvenkat inventvenkat Awaiting requested review from inventvenkat

Assignees

@NishantJoshi00 NishantJoshi00

Labels
A-core Area: Core flows A-framework Area: Framework
Projects
None yet
Milestone
May 2023 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@NishantJoshi00 @jarnura @ashokkjag