-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(connector): [Authorizedotnet]Fix webhooks #1261
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chikke srujan <[email protected]>
Signed-off-by: chikke srujan <[email protected]>
Signed-off-by: chikke srujan <[email protected]>
srujanchikke
added
A-connector-integration
Area: Connector integration
C-bug
Category: Bug
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
May 24, 2023
Signed-off-by: chikke srujan <[email protected]>
…orca into fix_webhooks_for_authorizedotnet
Signed-off-by: chikke srujan <[email protected]>
Signed-off-by: chikke srujan <[email protected]>
jarnura
previously approved these changes
May 25, 2023
Signed-off-by: chikke srujan <[email protected]>
jagan-jaya
approved these changes
May 25, 2023
ArjunKarthik
approved these changes
May 25, 2023
impl From<AuthorizedotnetWebhookEvent> for SyncStatus { | ||
fn from(event_type: AuthorizedotnetWebhookEvent) -> Self { | ||
match event_type { | ||
AuthorizedotnetWebhookEvent::AuthorizationCreated => Self::AuthorizedPendingCapture, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed please map the status accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
srujanchikke
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Fix Webhooks for authorizedotnet
status mapping reference : https://developer.authorize.net/api/reference/features/webhooks.html#Event_Types_and_Payloads
Additional Changes
Motivation and Context
How did you test it?
Payment
outgoing webhook for previous payment
Refund
outgoing Webhook for previously refunded transaction
Checklist
cargo +nightly fmt --all
cargo clippy