Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor(router): router_parameters field inclusion #1251

Merged
merged 4 commits into from
May 24, 2023
Merged

Refactor(router): router_parameters field inclusion #1251

merged 4 commits into from
May 24, 2023

Conversation

prajjwalkumar17
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Made changes in core/payments.rs to include a field named routing_parameters in Metadata Struct.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

This change is necessary for VAS in order to include routing using metadata which can be arbitrary key value pair.

How did you test it?

There is no requirement for test moreover it is Option so provides for backward compat.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@prajjwalkumar17 prajjwalkumar17 requested review from a team as code owners May 24, 2023 07:37
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label May 24, 2023
@prajjwalkumar17 prajjwalkumar17 self-assigned this May 24, 2023
@prajjwalkumar17 prajjwalkumar17 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor R-waiting-on-L1 Review: Waiting on L1 reviewer labels May 24, 2023
@prajjwalkumar17 prajjwalkumar17 changed the title Refactor/router_metadata field inclusion Refactor(router): router_metadata field inclusion May 24, 2023
@prajjwalkumar17 prajjwalkumar17 changed the title Refactor(router): router_metadata field inclusion Refactor(router): router_parameters field inclusion May 24, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label May 24, 2023
@prajjwalkumar17 prajjwalkumar17 added this to the May 2023 Release milestone May 24, 2023
@prajjwalkumar17 prajjwalkumar17 added R-waiting-on-L2 Review: Waiting on L2 reviewer R-L1-completed Review: L1 Review completed and removed R-waiting-on-L1 Review: Waiting on L1 reviewer labels May 24, 2023
@jarnura jarnura added this pull request to the merge queue May 24, 2023
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L2 Review: Waiting on L2 reviewer labels May 24, 2023
Merged via the queue into main with commit 16cd325 May 24, 2023
@prajjwalkumar17 prajjwalkumar17 removed the R-L1-completed Review: L1 Review completed label May 24, 2023
@jarnura jarnura deleted the feat/card_metadata_inclusion_smart_router branch May 24, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@vspecky vspecky vspecky approved these changes

@jarnura jarnura jarnura approved these changes

Assignees

@prajjwalkumar17 prajjwalkumar17

Labels
C-refactor Category: Refactor
Projects
None yet
Milestone
May 2023 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@prajjwalkumar17 @jarnura @vspecky @Narayanbhat166 @SanchithHegde