Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(logging): logging the request payload during BeginRequest #1247

Merged
merged 2 commits into from
May 25, 2023
Merged

feat(logging): logging the request payload during BeginRequest #1247

merged 2 commits into from
May 25, 2023

Conversation

NishantJoshi00
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR adds support for logging request payload in server_wrap

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@NishantJoshi00 NishantJoshi00 added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 23, 2023
@NishantJoshi00 NishantJoshi00 added this to the May 2023 Release milestone May 23, 2023
@NishantJoshi00 NishantJoshi00 self-assigned this May 23, 2023
@NishantJoshi00 NishantJoshi00 requested a review from a team as a code owner May 23, 2023 15:20
@lsampras
Copy link
Member

Can you elaborate on the requirement here...?

@ashokkjag
Copy link
Contributor

@NishantJoshi00 , payload may contain card or PII data. Logging must make sure they are masked/obfuscated.

@NishantJoshi00
Copy link
Member Author

@NishantJoshi00 , payload may contain card or PII data. Logging must make sure they are masked/obfuscated.

Yes @ashokkjag , when I tested this, the output actually prints as Debug implementation.
But, as @SanchithHegde pointed out, this would add this data in all the subsequent span, which isn't needed, so I'll change it to a simple log

@NishantJoshi00 NishantJoshi00 requested review from a team, jarnura and ashokkjag as code owners May 25, 2023 09:18
@jarnura jarnura enabled auto-merge May 25, 2023 09:34
@jarnura jarnura added this pull request to the merge queue May 25, 2023
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 25, 2023
Merged via the queue into main with commit 253eead May 25, 2023
@SanchithHegde SanchithHegde deleted the log-request-payload branch May 25, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura jarnura approved these changes

@inventvenkat inventvenkat inventvenkat approved these changes

@bernard-eugine bernard-eugine Awaiting requested review from bernard-eugine

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

Assignees

@NishantJoshi00 NishantJoshi00

Labels
A-core Area: Core flows
Projects
None yet
Milestone
May 2023 Release
Development

Successfully merging this pull request may close these issues.
6 participants
@NishantJoshi00 @lsampras @ashokkjag @inventvenkat @jarnura @SanchithHegde