Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: populate meta_data in payment_intent #1240

Merged
merged 1 commit into from
May 23, 2023
Merged

fix: populate meta_data in payment_intent #1240

merged 1 commit into from
May 23, 2023

Conversation

SamraatBansal
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Populate meta_data in PaymentIntent which in turn populate in PaymentsAuthorizeRouterData

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

The data inside metadata that was sent along with Payments Request was unable to be fetched while building the request for the connector.

How did you test it?

Tested the same for Zen and Klarna Via Adyen

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@SamraatBansal SamraatBansal requested a review from a team as a code owner May 23, 2023 11:01
@SamraatBansal SamraatBansal self-assigned this May 23, 2023
@SamraatBansal SamraatBansal added A-core Area: Core flows C-bug Category: Bug P-high Priority: High S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels May 23, 2023
@Narayanbhat166 Narayanbhat166 added this pull request to the merge queue May 23, 2023
@Narayanbhat166 Narayanbhat166 removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels May 23, 2023
Merged via the queue into main with commit 1ac3eb0 May 23, 2023
@SanchithHegde SanchithHegde deleted the bugfix/update-meta_data branch May 24, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@jarnura jarnura jarnura approved these changes

Assignees

@SamraatBansal SamraatBansal

Labels
A-core Area: Core flows C-bug Category: Bug P-high Priority: High
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamraatBansal @jarnura @Narayanbhat166