Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router): Validate payment_method_type in payments request against given payment method data for non-card flows #1236

Merged
merged 77 commits into from
Jul 27, 2023
Merged

feat(router): Validate payment_method_type in payments request against given payment method data for non-card flows #1236

merged 77 commits into from
Jul 27, 2023

Conversation

kritikmodi
Copy link
Contributor

@kritikmodi kritikmodi commented May 23, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature

Description

Added the following checks for non-card flows :

  1. Check if payment_method_type is specified.
  2. Check if the specified payment_method_type corresponds to the parent payment_method.
  3. Check if the specified payment_method_data corresponds to the parent payment_method.

Motivation and Context

This PR resolves this issue.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code

pixincreate and others added 30 commits April 19, 2023 22:05
@pixincreate
Remove CountryAlpha2 for CountryCode as it is been left redundant for…
13b9aba 
… some time now
@pixincreate
Refactor CountryCode for CountryAlpha2
710e7fe
@pixincreate
Move impl to transformers.rs
35eac22
@pixincreate
Fix schemas by replacing Country for CountryAlpha2
c84d6fb
@pixincreate
Merge branch 'main' of https://github.com/juspay/hyperswitch into ref…
dec9e4c 
…actor_countryCode
@pixincreate
Change CountryCode to CountryAlpha2 for Paypal
c8c8b77
@pixincreate
Merge branch 'main' of https://github.com/juspay/hyperswitch into ref…
40b1c23 
…actor_countryCode
@pixincreate
Address changes requested
bcf8092
@Narayanbhat166
fix: add the structs to openapi.rs file, and add
4364034 
value_type wherever required
@Narayanbhat166
Merge remote-tracking branch 'origin/main' into fix_openapi_file
efe4eeb
@Narayanbhat166
Merge with 'main'
0968ea2
@Narayanbhat166
docs: fix missing #[schema]
ce09e80
@Narayanbhat166
refactor: change schema types
db6a540
@Narayanbhat166
fix: format openapi file
d3bb1ac
@Narayanbhat166
feat: add paymentsCreateRequest schema
910bb8f
@Narayanbhat166
Merge branch 'main' into fix_openapi_file
4a328a6
@Narayanbhat166
doc: add structs to openapi file
b60d451
@Narayanbhat166
doc: fix Dispute spelling
fc36943
@Narayanbhat166
doc: fix pm_list endpoints
9ad3b36
@Narayanbhat166
doc: comment out admin apis
29a3b45
@Narayanbhat166
doc: generate openapi file
d093afa
@Narayanbhat166
Merge remote-tracking branch 'origin/main' into fix_openapi_file
9562041
@Narayanbhat166
macros: add PolymorphicMacro
1173c12
@Narayanbhat166
macros: use polymorphic macro
d2ead69
@Narayanbhat166
doc: add production url
0724c89
@Narayanbhat166
chore: cargo clippy
3147dfd
@Narayanbhat166
doc: generate openapi file
33fb097
@Narayanbhat166
Merge branch 'main' into fix_openapi_file
58a0cd5
@Narayanbhat166
doc: generate openapi file
27d5dca
@Narayanbhat166
macros: add doc comments
570e225
@sai-harsha-vardhan
Copy link
Contributor

@kritikmodi Please add the tests done locally

@kritikmodi
Copy link
Contributor Author

@kritikmodi Please add the tests done locally

Here are the local tests using Postman :

  • Scenario 1 : payment_method_type not passed :
Screen Shot 2023-07-26 at 7 22 30 PM
  • Scenario 2 : payment_method_data not passed :
Screen Shot 2023-07-26 at 7 22 40 PM
  • Scenario 3 : payment_method_type doesn't correspond with the given payment_method :
Screen Shot 2023-07-26 at 7 34 10 PM
  • Scenario 4 : payment_method_data doesn't correspond with the given payment_method :
Screen Shot 2023-07-26 at 7 23 04 PM
  • Scenario 5 : Both payment_method_type and payment_method_data are not passed :
Screen Shot 2023-07-26 at 7 34 20 PM

@SanchithHegde SanchithHegde added this pull request to the merge queue Jul 27, 2023
Merged via the queue into main with commit 7607b6b Jul 27, 2023
@SanchithHegde SanchithHegde deleted the issue1102-Kritik_Modi branch July 27, 2023 05:35
@kritikmodi kritikmodi mentioned this pull request Jul 27, 2023
Closed
2 tasks
@SanchithHegde SanchithHegde removed P-high Priority: High low-risk label to track PRs which might have less impact on hyperswitch after merge ageing >2weeks Created > 2 weeks labels Jul 27, 2023
@kritikmodi kritikmodi mentioned this pull request Jul 27, 2023
Merged
4 tasks
@kritikmodi kritikmodi changed the title feat(router): Validate payment method type in payments request against given payment method data for non-card flows feat(router): Validate payment_method_type in payments request against given payment method data for non-card flows Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prajjwalkumar17 prajjwalkumar17 prajjwalkumar17 approved these changes

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

@jarnura jarnura Awaiting requested review from jarnura

@vspecky vspecky Awaiting requested review from vspecky

Assignees

@kritikmodi kritikmodi

Labels
A-core Area: Core flows C-bug Category: Bug M-api-contract-changes Metadata: This PR involves API contract changes
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
July 2023 Release
Development

Successfully merging this pull request may close these issues.

[BUG] Validate payment method type in payments request against given payment method data for non-card flows
9 participants
@kritikmodi @SanchithHegde @sai-harsha-vardhan @jarnura @vspecky @prajjwalkumar17 @bernard-eugine @pixincreate @Narayanbhat166