Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connector): [Checkout] Fix error message in error handling #1221

Merged
merged 7 commits into from
May 29, 2023
Merged

fix(connector): [Checkout] Fix error message in error handling #1221

merged 7 commits into from
May 29, 2023

Conversation

prasunna09
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Updated the error message when an empty response is sent by the connector during authentication failure. Previously, when authentication failed at the connector, no error message was being sent.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Screenshot 2023-05-21 at 5 45 09 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@prasunna09 prasunna09 added A-connector-integration Area: Connector integration C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 21, 2023
@prasunna09 prasunna09 self-assigned this May 21, 2023
@prasunna09 prasunna09 requested a review from a team as a code owner May 21, 2023 12:16
HyperSwitchers
HyperSwitchers previously approved these changes May 21, 2023
View reviewed changes
jagan-jaya
jagan-jaya previously approved these changes May 21, 2023
View reviewed changes
@SanchithHegde SanchithHegde added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 21, 2023
@prasunna09 prasunna09 dismissed stale reviews from jagan-jaya and HyperSwitchers via 594e499 May 23, 2023 13:32
@prasunna09 prasunna09 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels May 23, 2023
@jagan-jaya jagan-jaya added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 25, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue May 29, 2023
Merged via the queue into main with commit 22b2fa3 May 29, 2023
@SanchithHegde SanchithHegde deleted the fix-checkout-error-handling branch May 29, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@jagan-jaya jagan-jaya jagan-jaya approved these changes

@HyperSwitchers HyperSwitchers HyperSwitchers left review comments

Assignees

@prasunna09 prasunna09

Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prasunna09 @jagan-jaya @ArjunKarthik @SanchithHegde @HyperSwitchers