test(connector): [Globalpay] Fix unit tests #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chikke srujan <[email protected]>
Signed-off-by: chikke srujan <[email protected]>
Signed-off-by: chikke srujan <[email protected]>
Signed-off-by: chikke srujan <[email protected]>
srujanchikke
added
A-connector-integration
SanchithHegde
changed the title
github-actions
bot
added
the
S-conventions-not-followed
SanchithHegde
changed the title
github-actions
bot
removed
the
S-conventions-not-followed
srujanchikke
added
the
S-waiting-on-review
SanchithHegde
previously approved these changes
May 22, 2023
jagan-jaya
requested changes
May 24, 2023
Cargo.lock
Outdated
| @@ -364,7 +364,6 @@ name = "api_models" | |||
| version = "0.1.0" | |||
| dependencies = [ | |||
| "actix-web", | |||
| "cards", | |||
There was a problem hiding this comment.
undo all the changes in this file
Signed-off-by: chikke srujan <[email protected]>
SanchithHegde
previously approved these changes
May 24, 2023
ArjunKarthik
requested changes
May 29, 2023
There was a problem hiding this comment.
@srujanchikke There are changes in the connector auth please add the label api contract changes. So that we can mark dashboard dependency while releasing this changes in the release announcements
| .make_payment( | ||
| Some(types::PaymentsAuthorizeData { | ||
| payment_method_data: types::api::PaymentMethodData::Card(api::Card { | ||
| card_number: cards::CardNumber::from_str("").unwrap(), |
There was a problem hiding this comment.
This test fails for empty card number can you rerun and check this?
| .make_payment( | ||
| Some(types::PaymentsAuthorizeData { | ||
| payment_method_data: types::api::PaymentMethodData::Card(api::Card { | ||
| card_number: cards::CardNumber::from_str("13241313413").unwrap(), |
There was a problem hiding this comment.
Same here, this would fail because of Kuhn check we have. Please rerun and check
ArjunKarthik
added
S-waiting-on-author
Signed-off-by: chikke srujan <[email protected]>
srujanchikke
added
S-waiting-on-review
jagan-jaya
approved these changes
May 30, 2023
ArjunKarthik
approved these changes
Jun 9, 2023
jagan-jaya
added
S-ready-for-merge
and removed
S-waiting-on-review
SanchithHegde
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR contains following changes
1)unit tests for globalpay
2)expiry year fix
Additional Changes
Motivation and Context
unit tests for globalpay
How did you test it?
unit tests
Note :
should_fail_void_payment_for_auto_captureis failing from connector end .Checklist
cargo +nightly fmt --allcargo clippy