Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(utils): fix bug in email validation #1180

Merged
merged 2 commits into from
May 18, 2023
Merged

fix(utils): fix bug in email validation #1180

merged 2 commits into from
May 18, 2023

Conversation

apoorvdixit88
Copy link
Contributor

@apoorvdixit88 apoorvdixit88 commented May 17, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Fixed the email deserialization.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@apoorvdixit88 apoorvdixit88 requested a review from a team as a code owner May 17, 2023 09:34
@apoorvdixit88 apoorvdixit88 added C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels May 17, 2023
@apoorvdixit88 apoorvdixit88 force-pushed the bugfix-email-validation branch 2 times, most recently from 70cff39 to 298f7e2 Compare May 17, 2023 10:50
SanchithHegde
SanchithHegde reviewed May 17, 2023
View reviewed changes
crates/common_utils/src/pii.rs Outdated Show resolved Hide resolved
crates/common_utils/src/pii.rs Outdated Show resolved Hide resolved
@SanchithHegde SanchithHegde added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels May 17, 2023
@SanchithHegde SanchithHegde added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels May 17, 2023
@apoorvdixit88 apoorvdixit88 added the R-waiting-on-L2 Review: Waiting on L2 reviewer label May 17, 2023
@jarnura jarnura added this pull request to the merge queue May 18, 2023
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L2 Review: Waiting on L2 reviewer labels May 18, 2023
Merged via the queue into main with commit 5e51b6b May 18, 2023
@ThisIsMani ThisIsMani deleted the bugfix-email-validation branch May 18, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vspecky vspecky vspecky approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@lsampras lsampras lsampras approved these changes

@jarnura jarnura jarnura approved these changes

Assignees

@apoorvdixit88 apoorvdixit88

Labels
C-bug Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@apoorvdixit88 @jarnura @lsampras @SanchithHegde @vspecky